From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYXJD-0000Q1-Cp for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:31:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYXJ9-0007it-AR for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:31:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYXJ9-0007hp-3C for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:31:51 -0400 From: Gerd Hoffmann Date: Mon, 29 Sep 2014 11:31:08 +0200 Message-Id: <1411983073-13058-8-git-send-email-kraxel@redhat.com> In-Reply-To: <1411983073-13058-1-git-send-email-kraxel@redhat.com> References: <1411983073-13058-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH v2 07/11] vga: Remove some "should be done in BIOS" comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , David Gibson From: Benjamin Herrenschmidt Not all platforms have a VGA BIOS, powerpc typically relies on using the DISPI interface to initialize the card. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann Reviewed-by: David Gibson --- hw/display/vga.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index c3df0c5..21aa2c6 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -761,14 +761,13 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val) s->vbe_regs[VBE_DISPI_INDEX_ENABLE] |= VBE_DISPI_ENABLED; vbe_fixup_regs(s); - /* clear the screen (should be done in BIOS) */ + /* clear the screen */ if (!(val & VBE_DISPI_NOCLEARMEM)) { memset(s->vram_ptr, 0, s->vbe_regs[VBE_DISPI_INDEX_YRES] * s->vbe_line_offset); } - /* we initialize the VGA graphic mode (should be done - in BIOS) */ + /* we initialize the VGA graphic mode */ /* graphic mode + memory map 1 */ s->gr[VGA_GFX_MISC] = (s->gr[VGA_GFX_MISC] & ~0x0c) | 0x04 | VGA_GR06_GRAPHICS_MODE; @@ -801,7 +800,6 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val) (shift_control << 5); s->cr[VGA_CRTC_MAX_SCAN] &= ~0x9f; /* no double scan */ } else { - /* XXX: the bios should do that */ s->bank_offset = 0; } s->dac_8bit = (val & VBE_DISPI_8BIT_DAC) > 0; -- 1.8.3.1