From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYgDg-0002W1-7Q for qemu-devel@nongnu.org; Mon, 29 Sep 2014 15:02:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYgDZ-0001xx-A0 for qemu-devel@nongnu.org; Mon, 29 Sep 2014 15:02:48 -0400 Received: from mail-ig0-x236.google.com ([2607:f8b0:4001:c05::236]:50121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYgDZ-0001xF-5P for qemu-devel@nongnu.org; Mon, 29 Sep 2014 15:02:41 -0400 Received: by mail-ig0-f182.google.com with SMTP id hn18so4021301igb.9 for ; Mon, 29 Sep 2014 12:02:35 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Mon, 29 Sep 2014 12:01:52 -0700 Message-Id: <1412017318-4331-4-git-send-email-rth@twiddle.net> In-Reply-To: <1412017318-4331-1-git-send-email-rth@twiddle.net> References: <1412017318-4331-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL v2 3/9] tcg-sparc: Fix setcond_i32 uninitialized value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org We failed to swap c1 and c2 correctly for NE c2 == 0. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 08ca482..3b232d6 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -674,9 +674,12 @@ static void tcg_out_setcond_i32(TCGContext *s, TCGCond cond, TCGReg ret, case TCG_COND_NE: /* For equality, we can transform to inequality vs zero. */ if (c2 != 0) { - tcg_out_arithc(s, ret, c1, c2, c2const, ARITH_XOR); + tcg_out_arithc(s, TCG_REG_T1, c1, c2, c2const, ARITH_XOR); + c2 = TCG_REG_T1; + } else { + c2 = c1; } - c1 = TCG_REG_G0, c2 = ret, c2const = 0; + c1 = TCG_REG_G0, c2const = 0; cond = (cond == TCG_COND_EQ ? TCG_COND_GEU : TCG_COND_LTU); break; -- 1.9.3