From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] add input-send-event command
Date: Tue, 30 Sep 2014 08:51:14 +0200 [thread overview]
Message-ID: <1412059874.23471.2.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20140929193045.GA30934@amt.cnet>
Hi,
> > 'console' is mandatory; I guess that's okay.
> >
> > Are we guaranteed that either all events are sent? Or is there a need to
>
> Events can be dropped at hardware level if the event queue is full, for
> example. Would have to modify individual drivers to return error codes,
> i suppose. Gerd?
Events can be dropped at hardware level indeed. Hard to check
beforehand, and we don't even return errors today as the ui code (which
would see the error) can't do much about it. Not sure this is worth
changing, this usually only happens in case the guest has trouble
driving the device, in which case you have bigger problems anyway.
Events can also be dropped because there is no device they can be
delivered to. This can easily be checked for the whole event list
before you start sending the events, just call qemu_input_find_handler()
and see whenever it returns a handler or not. So we can go for a
"all-or-nothing" model here. In the x86 world this can happen with
absolute mouse moves only because there is always a ps2 kbd+mouse.
cheers,
Gerd
prev parent reply other threads:[~2014-09-30 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 18:56 [Qemu-devel] [PATCH v3] add input-send-event command Marcelo Tosatti
2014-09-29 19:12 ` Eric Blake
2014-09-29 19:30 ` Marcelo Tosatti
2014-09-30 6:51 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412059874.23471.2.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=akong@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).