From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
David Gibson <dgibson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] vga-pci: add qext region to mmio
Date: Tue, 30 Sep 2014 13:02:12 +0200 [thread overview]
Message-ID: <1412074932.23471.14.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20140929161836.GD21268@redhat.com>
On Mo, 2014-09-29 at 19:18 +0300, Michael S. Tsirkin wrote:
> > + .driver = "VGA",\
> > + .property = "qext",\
> > + .value = "off",\
>
> I'd prefer a more friendly name like "qemu-extended-registers".
> There's very little documentation for properties besides
> the name, so the name has to be explicit.
Done.
cheers,
Gerd
next prev parent reply other threads:[~2014-09-30 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 12:30 [Qemu-devel] [PATCH 0/3] vga: add endianness switching support Gerd Hoffmann
2014-09-23 12:30 ` [Qemu-devel] [PATCH 1/3] vga: Make fb endian a common state variable Gerd Hoffmann
2014-09-26 4:28 ` David Gibson
2014-09-23 12:30 ` [Qemu-devel] [PATCH 2/3] vga: Add endian control register Gerd Hoffmann
2014-09-26 4:34 ` David Gibson
2014-09-23 12:30 ` [Qemu-devel] [PATCH 3/3] vga-pci: add qext region to mmio Gerd Hoffmann
2014-09-26 4:38 ` David Gibson
2014-09-29 16:18 ` Michael S. Tsirkin
2014-09-30 11:02 ` Gerd Hoffmann [this message]
2014-09-23 20:24 ` [Qemu-devel] [PATCH 0/3] vga: add endianness switching support Benjamin Herrenschmidt
2014-09-23 20:33 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412074932.23471.14.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=dgibson@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).