From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYvaX-00045u-6P for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:27:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYvaR-0005Xx-KX for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:27:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYvaR-0005Wn-Cy for qemu-devel@nongnu.org; Tue, 30 Sep 2014 07:27:19 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8UBRDHa026470 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 30 Sep 2014 07:27:14 -0400 From: Kevin Wolf Date: Tue, 30 Sep 2014 13:27:09 +0200 Message-Id: <1412076430-11623-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1412076430-11623-1-git-send-email-kwolf@redhat.com> References: <1412076430-11623-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] make check-block: Use default cache modes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com When qemu-iotests only gave a choice between cache=none and cache=writethrough, we picked cache=none because it was the option that would complete the test in finite time. Some tests could only work for one of the two options and would be skipped with cache=none, but that was an acceptable trade-off at the time. Today, however, qemu-iotests is a bit more flexible than that and you can specify any of the cache modes supported by qemu. The default is writeback, like in qemu, which is fast and (unlike cache=none) compatible with any host filesystem. Test cases that have specific requirements for the cache mode can also specify a different default. In order to get a fast test run that works everywhere and doesn't skip tests that need a different cache mode, not specifying any cache mode and instead relying on the default is the best we can do today. Signed-off-by: Kevin Wolf --- tests/qemu-iotests-quick.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests-quick.sh b/tests/qemu-iotests-quick.sh index 8a9a4c6..12af731 100755 --- a/tests/qemu-iotests-quick.sh +++ b/tests/qemu-iotests-quick.sh @@ -3,6 +3,6 @@ cd tests/qemu-iotests ret=0 -./check -T -nocache -qcow2 -g quick || ret=1 +./check -T -qcow2 -g quick || ret=1 exit $ret -- 1.8.3.1