From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzHX-0000mj-6u for qemu-devel@nongnu.org; Tue, 30 Sep 2014 11:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYzHR-0001pA-43 for qemu-devel@nongnu.org; Tue, 30 Sep 2014 11:24:03 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:58987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzHQ-0001p1-Qy for qemu-devel@nongnu.org; Tue, 30 Sep 2014 11:23:57 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Sep 2014 16:23:55 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5DD211B0806B for ; Tue, 30 Sep 2014 16:25:05 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8UFNrj135651778 for ; Tue, 30 Sep 2014 15:23:53 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8UFNqsM030996 for ; Tue, 30 Sep 2014 09:23:52 -0600 From: Jens Freimann Date: Tue, 30 Sep 2014 17:23:47 +0200 Message-Id: <1412090627-18709-2-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: <1412090627-18709-1-git-send-email-jfrei@linux.vnet.ibm.com> References: <1412090627-18709-1-git-send-email-jfrei@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Alexander Graf , Cornelia Huck Cc: Peter Maydell , qemu-devel@nongnu.org, David Hildenbrand , Jens Freimann , "Vassili Karpov (malc)" , Edgar Iglesias , Richard Henderson From: David Hildenbrand This patch provides the name of the architecture in the target.xml if available. This allows the remote gdb to detect the target architecture on its own - so there is no need to specify it manually (e.g. if gdb is started without a binary) using "set arch *arch_name*". The name of the architecture has been added to all archs that provide a target.xml (by supplying a gdb_core_xml_file) and have a unique architecture name in gdb's feature xml files. Signed-off-by: David Hildenbrand Acked-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: Jens Freimann Reviewed-by: Andreas Färber Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: Vassili Karpov (malc) CC: Edgar Iglesias CC: Richard Henderson --- gdbstub.c | 19 ++++++++++++------- include/qom/cpu.h | 2 ++ target-arm/cpu64.c | 1 + target-ppc/translate_init.c | 2 ++ target-s390x/cpu.c | 1 + 5 files changed, 18 insertions(+), 7 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 71aaa23..21d78f8 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -523,13 +523,18 @@ static const char *get_feature_xml(const char *p, const char **newp, GDBRegisterState *r; CPUState *cpu = first_cpu; - snprintf(target_xml, sizeof(target_xml), - "" - "" - "" - "", - cc->gdb_core_xml_file); - + pstrcat(target_xml, sizeof(target_xml), + "" + "" + ""); + if (cc->gdb_arch_name) { + pstrcat(target_xml, sizeof(target_xml), ""); + pstrcat(target_xml, sizeof(target_xml), cc->gdb_arch_name); + pstrcat(target_xml, sizeof(target_xml), ""); + } + pstrcat(target_xml, sizeof(target_xml), "gdb_core_xml_file); + pstrcat(target_xml, sizeof(target_xml), "\"/>"); for (r = cpu->gdb_regs; r; r = r->next) { pstrcat(target_xml, sizeof(target_xml), "xml); diff --git a/include/qom/cpu.h b/include/qom/cpu.h index f576b47..0ceb99d 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -99,6 +99,7 @@ struct TranslationBlock; * @vmsd: State description for migration. * @gdb_num_core_regs: Number of core registers accessible to GDB. * @gdb_core_xml_file: File name for core registers GDB XML description. + * @gdb_arch_name: Architecture name known to GDB. * @cpu_exec_enter: Callback for cpu_exec preparation. * @cpu_exec_exit: Callback for cpu_exec cleanup. * @cpu_exec_interrupt: Callback for processing interrupts in cpu_exec. @@ -152,6 +153,7 @@ typedef struct CPUClass { const struct VMStateDescription *vmsd; int gdb_num_core_regs; const char *gdb_core_xml_file; + const char *gdb_arch_name; void (*cpu_exec_enter)(CPUState *cpu); void (*cpu_exec_exit)(CPUState *cpu); diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index c30f47e..a2b855c 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -203,6 +203,7 @@ static void aarch64_cpu_class_init(ObjectClass *oc, void *data) cc->gdb_write_register = aarch64_cpu_gdb_write_register; cc->gdb_num_core_regs = 34; cc->gdb_core_xml_file = "aarch64-core.xml"; + cc->gdb_arch_name = "aarch64"; } static void aarch64_cpu_register(const ARMCPUInfo *info) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 65b840d..bd9a26f 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -9659,8 +9659,10 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data) #if defined(TARGET_PPC64) cc->gdb_core_xml_file = "power64-core.xml"; + cc->gdb_arch_name = "powerpc:common64"; #else cc->gdb_core_xml_file = "power-core.xml"; + cc->gdb_arch_name = "powerpc:common"; #endif #ifndef CONFIG_USER_ONLY cc->virtio_is_big_endian = ppc_cpu_is_big_endian; diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index c9c237f..8447701 100644 --- a/target-s390x/cpu.c +++ b/target-s390x/cpu.c @@ -385,6 +385,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data) #endif cc->gdb_num_core_regs = S390_NUM_CORE_REGS; cc->gdb_core_xml_file = "s390x-core64.xml"; + cc->gdb_arch_name = "s390:64-bit"; } static const TypeInfo s390_cpu_type_info = { -- 1.8.5.5