From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, benoit.canet@nodalink.com, stefanha@redhat.com,
mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v4 16/23] ide: Complete conversion from BlockDriverState to BlockBackend
Date: Tue, 30 Sep 2014 21:25:37 +0200 [thread overview]
Message-ID: <1412105144-532-17-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1412105144-532-1-git-send-email-armbru@redhat.com>
Add a BlockBackend member to TrimAIOCB, so ide_issue_trim_cb() can use
blk_aio_discard() instead of bdrv_aio_discard().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
hw/ide/core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 5d3d988..2e8b7d6 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -362,6 +362,7 @@ static void ide_set_signature(IDEState *s)
typedef struct TrimAIOCB {
BlockAIOCB common;
+ BlockBackend *blk;
QEMUBH *bh;
int ret;
QEMUIOVector *qiov;
@@ -421,8 +422,8 @@ static void ide_issue_trim_cb(void *opaque, int ret)
}
/* Got an entry! Submit and exit. */
- iocb->aiocb = bdrv_aio_discard(iocb->common.bs, sector, count,
- ide_issue_trim_cb, opaque);
+ iocb->aiocb = blk_aio_discard(iocb->blk, sector, count,
+ ide_issue_trim_cb, opaque);
return;
}
@@ -446,6 +447,7 @@ BlockAIOCB *ide_issue_trim(BlockBackend *blk,
TrimAIOCB *iocb;
iocb = blk_aio_get(&trim_aiocb_info, blk, cb, opaque);
+ iocb->blk = blk;
iocb->bh = qemu_bh_new(ide_trim_bh_cb, iocb);
iocb->ret = 0;
iocb->qiov = qiov;
--
1.9.3
next prev parent reply other threads:[~2014-09-30 19:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 19:25 [Qemu-devel] [PATCH v4 00/23] Split BlockBackend off BDS with an axe Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 01/23] block: Split bdrv_new_root() off bdrv_new() Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 02/23] block: New BlockBackend Markus Armbruster
2014-10-01 15:27 ` Max Reitz
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 03/23] block: Connect BlockBackend to BlockDriverState Markus Armbruster
2014-10-01 15:34 ` Max Reitz
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 04/23] block: Connect BlockBackend and DriveInfo Markus Armbruster
2014-10-01 15:52 ` Max Reitz
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 05/23] block: Code motion to get rid of stubs/blockdev.c Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 06/23] block: Make BlockBackend own its BlockDriverState Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 07/23] block: Eliminate bdrv_iterate(), use bdrv_next() Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 08/23] block: Eliminate BlockDriverState member device_name[] Markus Armbruster
2014-10-01 16:19 ` Max Reitz
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 09/23] block: Merge BlockBackend and BlockDriverState name spaces Markus Armbruster
2014-10-01 16:20 ` Max Reitz
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo() Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB* Markus Armbruster
2014-10-01 16:50 ` Max Reitz
2014-10-02 7:03 ` Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 12/23] block: Rename BlockDriverCompletionFunc to BlockCompletionFunc Markus Armbruster
2014-10-01 16:55 ` Max Reitz
2014-10-02 7:12 ` Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 13/23] virtio-blk: Drop redundant VirtIOBlock member conf Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 14/23] virtio-blk: Rename VirtIOBlkConf variables to conf Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 15/23] hw: Convert from BlockDriverState to BlockBackend, mostly Markus Armbruster
2014-10-01 17:09 ` Max Reitz
2014-10-02 7:14 ` Markus Armbruster
2014-09-30 19:25 ` Markus Armbruster [this message]
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 17/23] pc87312: Drop unused members of PC87312State Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 18/23] blockdev: Drop superfluous DriveInfo member id Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 19/23] blockdev: Fix blockdev-add not to create DriveInfo Markus Armbruster
2014-10-01 17:21 ` Max Reitz
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 20/23] block/qapi: Convert qmp_query_block() to BlockBackend Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 21/23] blockdev: Convert qmp_eject(), qmp_change_blockdev() " Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 22/23] block: Lift device model API into BlockBackend Markus Armbruster
2014-09-30 19:25 ` [Qemu-devel] [PATCH v4 23/23] block: Make device model's references to BlockBackend strong Markus Armbruster
2014-10-01 17:22 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412105144-532-17-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).