From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Filter out system includes for pixman
Date: Thu, 02 Oct 2014 09:43:16 +0200 [thread overview]
Message-ID: <1412235796.2786.1.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <542CFB46.80209@siemens.com>
On Do, 2014-10-02 at 09:14 +0200, Jan Kiszka wrote:
> Other packages may provide includes for pixman as well if the host has a
> devel package installed. Remove them from QEMU_CFLAGS before adding our
> version to unsure that the right headers are used.
Hmm, how does that happen? Shouldn't qemu use the system pixman if
present? Well, maybe not in case it is too old ...
I think we should just reverse the ordering, so our pixman submodule
comes first in the include path list. And it is probably a good idea to
do the same for fdt.
cheers,
Gerd
prev parent reply other threads:[~2014-10-02 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 7:14 [Qemu-devel] [PATCH] configure: Filter out system includes for pixman Jan Kiszka
2014-10-02 7:43 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412235796.2786.1.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).