From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZb2s-0003Az-Ks for qemu-devel@nongnu.org; Thu, 02 Oct 2014 03:43:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZb2m-0007os-H9 for qemu-devel@nongnu.org; Thu, 02 Oct 2014 03:43:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZb2m-0007mm-9p for qemu-devel@nongnu.org; Thu, 02 Oct 2014 03:43:20 -0400 Message-ID: <1412235796.2786.1.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 02 Oct 2014 09:43:16 +0200 In-Reply-To: <542CFB46.80209@siemens.com> References: <542CFB46.80209@siemens.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: Filter out system includes for pixman List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On Do, 2014-10-02 at 09:14 +0200, Jan Kiszka wrote: > Other packages may provide includes for pixman as well if the host has a > devel package installed. Remove them from QEMU_CFLAGS before adding our > version to unsure that the right headers are used. Hmm, how does that happen? Shouldn't qemu use the system pixman if present? Well, maybe not in case it is too old ... I think we should just reverse the ordering, so our pixman submodule comes first in the include path list. And it is probably a good idea to do the same for fdt. cheers, Gerd