qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 05/10] vga: Simplify vga_draw_blank() a bit
Date: Thu,  2 Oct 2014 09:44:28 +0200	[thread overview]
Message-ID: <1412235873-19202-6-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1412235873-19202-1-git-send-email-kraxel@redhat.com>

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

The test for surface_bits_per_pixel() isn't necessary anymore,
the 8bpp case never happens.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/display/vga.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/hw/display/vga.c b/hw/display/vga.c
index 9d06691..c3df0c5 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1682,7 +1682,7 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
 static void vga_draw_blank(VGACommonState *s, int full_update)
 {
     DisplaySurface *surface = qemu_console_surface(s->con);
-    int i, w, val;
+    int i, w;
     uint8_t *d;
 
     if (!full_update)
@@ -1690,15 +1690,10 @@ static void vga_draw_blank(VGACommonState *s, int full_update)
     if (s->last_scr_width <= 0 || s->last_scr_height <= 0)
         return;
 
-    if (surface_bits_per_pixel(surface) == 8) {
-        val = rgb_to_pixel32(0, 0, 0);
-    } else {
-        val = 0;
-    }
     w = s->last_scr_width * surface_bytes_per_pixel(surface);
     d = surface_data(surface);
     for(i = 0; i < s->last_scr_height; i++) {
-        memset(d, val, w);
+        memset(d, 0, w);
         d += surface_stride(surface);
     }
     dpy_gfx_update(s->con, 0, 0,
-- 
1.8.3.1

  parent reply	other threads:[~2014-10-02  7:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02  7:44 [Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 01/10] vga: Start cutting out non-32bpp conversion support Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 02/10] vga: Remove remainder of old conversion cruft Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 03/10] vga: Separate LE and BE conversion functions Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 04/10] vga: Remove rgb_to_pixel indirection Gerd Hoffmann
2014-10-02  7:44 ` Gerd Hoffmann [this message]
2014-10-02  7:44 ` [Qemu-devel] [PULL 06/10] cirrus: Remove non-32bpp cursor drawing Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 07/10] vga: Remove some "should be done in BIOS" comments Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 08/10] vga: Rename vga_template.h to vga-helpers.h Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 09/10] vga: Make fb endian a common state variable Gerd Hoffmann
2014-10-02  7:44 ` [Qemu-devel] [PULL 10/10] vga: Add endian to vmstate Gerd Hoffmann
2014-10-02 12:23 ` [Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412235873-19202-6-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).