From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 07/10] vga: Remove some "should be done in BIOS" comments
Date: Thu, 2 Oct 2014 09:44:30 +0200 [thread overview]
Message-ID: <1412235873-19202-8-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1412235873-19202-1-git-send-email-kraxel@redhat.com>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Not all platforms have a VGA BIOS, powerpc typically relies on
using the DISPI interface to initialize the card.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/display/vga.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index c3df0c5..21aa2c6 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -761,14 +761,13 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)
s->vbe_regs[VBE_DISPI_INDEX_ENABLE] |= VBE_DISPI_ENABLED;
vbe_fixup_regs(s);
- /* clear the screen (should be done in BIOS) */
+ /* clear the screen */
if (!(val & VBE_DISPI_NOCLEARMEM)) {
memset(s->vram_ptr, 0,
s->vbe_regs[VBE_DISPI_INDEX_YRES] * s->vbe_line_offset);
}
- /* we initialize the VGA graphic mode (should be done
- in BIOS) */
+ /* we initialize the VGA graphic mode */
/* graphic mode + memory map 1 */
s->gr[VGA_GFX_MISC] = (s->gr[VGA_GFX_MISC] & ~0x0c) | 0x04 |
VGA_GR06_GRAPHICS_MODE;
@@ -801,7 +800,6 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)
(shift_control << 5);
s->cr[VGA_CRTC_MAX_SCAN] &= ~0x9f; /* no double scan */
} else {
- /* XXX: the bios should do that */
s->bank_offset = 0;
}
s->dac_8bit = (val & VBE_DISPI_8BIT_DAC) > 0;
--
1.8.3.1
next prev parent reply other threads:[~2014-10-02 7:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 7:44 [Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 01/10] vga: Start cutting out non-32bpp conversion support Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 02/10] vga: Remove remainder of old conversion cruft Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 03/10] vga: Separate LE and BE conversion functions Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 04/10] vga: Remove rgb_to_pixel indirection Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 05/10] vga: Simplify vga_draw_blank() a bit Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 06/10] cirrus: Remove non-32bpp cursor drawing Gerd Hoffmann
2014-10-02 7:44 ` Gerd Hoffmann [this message]
2014-10-02 7:44 ` [Qemu-devel] [PULL 08/10] vga: Rename vga_template.h to vga-helpers.h Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 09/10] vga: Make fb endian a common state variable Gerd Hoffmann
2014-10-02 7:44 ` [Qemu-devel] [PULL 10/10] vga: Add endian to vmstate Gerd Hoffmann
2014-10-02 12:23 ` [Qemu-devel] [PULL 00/10] vga: cleanups, prepare for endianness switching Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412235873-19202-8-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).