From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZbVE-0005fH-79 for qemu-devel@nongnu.org; Thu, 02 Oct 2014 04:12:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZbV7-0000HU-LC for qemu-devel@nongnu.org; Thu, 02 Oct 2014 04:12:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZbV7-0000HO-Cf for qemu-devel@nongnu.org; Thu, 02 Oct 2014 04:12:37 -0400 From: Gerd Hoffmann Date: Thu, 2 Oct 2014 10:12:28 +0200 Message-Id: <1412237549-1507-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1412237549-1507-1-git-send-email-kraxel@redhat.com> References: <1412237549-1507-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/2] input: fix send-key monitor command release event ordering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amos Kong , Gerd Hoffmann , Anthony Liguori commit 2e377f1730d06deafb3e3ef6cf88792de4a6f4df changed the ordering of the release events as side effect. Some guests are not happy with that and don't recognise ctrl-alt-del any more. This patch restores the old last-pressed first-released behavior. Cc: Amos Kong Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 3025f50..a698a34 100644 --- a/ui/input-legacy.c +++ b/ui/input-legacy.c @@ -85,6 +85,8 @@ void qmp_send_key(KeyValueList *keys, bool has_hold_time, int64_t hold_time, Error **errp) { KeyValueList *p; + KeyValue **up = NULL; + int count = 0; if (!has_hold_time) { hold_time = 0; /* use default */ @@ -93,11 +95,16 @@ void qmp_send_key(KeyValueList *keys, bool has_hold_time, int64_t hold_time, for (p = keys; p != NULL; p = p->next) { qemu_input_event_send_key(NULL, copy_key_value(p->value), true); qemu_input_event_send_key_delay(hold_time); + up = g_realloc(up, sizeof(*up) * (count+1)); + up[count] = copy_key_value(p->value); + count++; } - for (p = keys; p != NULL; p = p->next) { - qemu_input_event_send_key(NULL, copy_key_value(p->value), false); + while (count) { + count--; + qemu_input_event_send_key(NULL, up[count], false); qemu_input_event_send_key_delay(hold_time); } + g_free(up); } static void legacy_kbd_event(DeviceState *dev, QemuConsole *src, -- 1.8.3.1