From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZhjQ-0004y0-To for qemu-devel@nongnu.org; Thu, 02 Oct 2014 10:51:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZhjI-0003Tl-4M for qemu-devel@nongnu.org; Thu, 02 Oct 2014 10:51:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZhjH-0003TO-To for qemu-devel@nongnu.org; Thu, 02 Oct 2014 10:51:40 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s92Epd3b006768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 2 Oct 2014 10:51:39 -0400 From: Markus Armbruster Date: Thu, 2 Oct 2014 16:51:33 +0200 Message-Id: <1412261496-24455-4-git-send-email-armbru@redhat.com> In-Reply-To: <1412261496-24455-1-git-send-email-armbru@redhat.com> References: <1412261496-24455-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com The first argument should be a PCI address, which pci-addr=auto isn't. Doesn't really matter, as drive_add ignores its first argument when its second argument has if=none. Clean it up anyway. Signed-off-by: Markus Armbruster --- tests/drive_del-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c index 786f026..67309fd 100644 --- a/tests/drive_del-test.c +++ b/tests/drive_del-test.c @@ -83,7 +83,7 @@ static void test_after_failed_device_add(void) */ response = qmp("{'execute': 'human-monitor-command'," " 'arguments': {" - " 'command-line': 'drive_add pci-addr=auto if=none,id=drive0'" + " 'command-line': 'drive_add 0 if=none,id=drive0'" "}}"); g_assert(response); g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "OK\r\n"); -- 1.9.3