From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46080)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XZyoY-0000ch-Ae
	for qemu-devel@nongnu.org; Fri, 03 Oct 2014 05:06:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XZyoS-0006J3-6O
	for qemu-devel@nongnu.org; Fri, 03 Oct 2014 05:06:14 -0400
Received: from smtp.citrix.com ([66.165.176.89]:21707)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XZyoS-0006Iv-1v
	for qemu-devel@nongnu.org; Fri, 03 Oct 2014 05:06:08 -0400
Message-ID: <1412327164.423.15.camel@citrix.com>
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Fri, 3 Oct 2014 10:06:04 +0100
In-Reply-To: <6624BC057AF4E240B6D036F5CC505B12041F5382@AMSPEX01CL02.citrite.net>
References: <1411376699-8175-1-git-send-email-owen.smith@citrix.com>
	<1411376699-8175-3-git-send-email-owen.smith@citrix.com>
	<541FF6F8.3030906@citrix.com>
	<6624BC057AF4E240B6D036F5CC505B12041F5382@AMSPEX01CL02.citrite.net>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: Add comment
	documentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Owen Smith <owen.smith@citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefano Stabellini <Stefano.Stabellini@citrix.com>, David Vrabel <david.vrabel@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>

On Fri, 2014-09-26 at 11:20 +0100, Owen Smith wrote:
> > > + * page-gref
> > > + *   Values: <uint32_t>
> > > + *   Only required if "page-ref" is NOT set.
> > > + *
> > > + *   A grant reference to the memory page to be mapped for the shared
> > ring
> > > + *   structures. Must be present if "page-ref" is not present.
> > 
> > Should there be some negotiation for which of page-ref or page-gref is
> > required/preferred by the backend?
> > 
> > The same applies to kbdif as well.
> > 
> 
> I've not added negotiation, as I wanted minimum changes when "page-ref" is specified.
> With the kbdif device only, not investigated the vfb, a backend only supporting "page-gref" 
> will break a lot of frontends (I saw breaks in Ubuntu, which advertises both if I forced page-gref)

Is this patch/series documenting existing behaviour or the new behaviour
which you are currently implementing? Both patches have the same title
and essentially the same commit message (list of fields), so I can't
tell.