From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp,
lilei@linux.vnet.ibm.com, quintela@redhat.com,
cristian.klein@cs.umu.se, amit.shah@redhat.com,
yanghy@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH v4 00/47] Postcopy implementation
Date: Fri, 3 Oct 2014 18:47:06 +0100 [thread overview]
Message-ID: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Hi,
This is the 4th cut of my version of postcopy; it is designed for use with
the Linux kernel additions just posted by Andrea Arcangeli here:
http://marc.info/?l=linux-kernel&m=141235633015100&w=2
(Note: This is a new version compared to my previous postcopy patchset; you'll
need to update the kernel to the new version.)
Other than the new kernel ABI (which is only a small change to the userspace side);
the major changes are;
a) Code for host page size != target page size
b) Support for migration over fd
From Cristian Klein; this is for libvirt support which Cristian recently
posted to the libvirt list.
c) It's now build bisectable and builds on 32bit
Testing wise; I've now done many thousand of postcopy migrations without
failure (both of idle and busy guests); so it seems pretty solid.
Must-TODO's:
1) A partially repeatable migration_cancel failure
2) virt_test's migrate.with_reboot test is failing
3) The ACPI fix in 2.1 that allowed migrating RAMBlocks to be larger than
the source feels like it needs looking at for postcopy.
4) Paolo's comments with respect to the wakeup_request/is_running code
in the migration thread
5) xbzrle needs disabling once in postcopy
Later-TODO's:
1) Control the rate of background page transfers during postcopy to
reduce their impact on the latency of postcopy requests.
2) Work with RDMA
3) Could destination RP be made blocking (as per discussion with Paolo;
I'm still worried that that changes too many assumptions)
V4:
Initial support for host page size != target page size
- tested heavily on hps==tps
- only partially tested on hps!=tps systems
- This involved quite a bit of rework around the discard code
Updated to new kernel userfault ABI
- It won't work with the previous version
Fix mis-optimisation of postcopy request for wrong RAMBlock
request for block A offset n
un-needed fault for block B/m (already received - no req sent)
request for block B/l - wrongly sent as request for A/l
Fix thinko in discard bitmap processing (missed last word of bitmap)
Symptom: remap failures near the top of RAM if postcopy started late
Fix bug that caused kernel page acknowledgments to be misaligned
May have meant the guest was paused for longer than required
Fix potential for crashing cleaning up failed RP
Fixes in docs (from Yang)
Handle migration by fd as sockets if they are sockets
Build tested on 32bit
Fully build bisectable (x86-64)
Dave
Cristian Klein (1):
Handle bi-directional communication for fd migration
Dr. David Alan Gilbert (46):
QEMUSizedBuffer based QEMUFile
Tests: QEMUSizedBuffer/QEMUBuffer
Start documenting how postcopy works.
qemu_ram_foreach_block: pass up error value, and down the ramblock
name
improve DPRINTF macros, add to savevm
Add qemu_get_counted_string to read a string prefixed by a count byte
Create MigrationIncomingState
socket shutdown
Provide runtime Target page information
Return path: Open a return path on QEMUFile for sockets
Return path: socket_writev_buffer: Block even on non-blocking fd's
Migration commands
Return path: Control commands
Return path: Send responses from destination to source
Return path: Source handling of return path
qemu_loadvm errors and debug
ram_debug_dump_bitmap: Dump a migration bitmap as text
Rework loadvm path for subloops
Add migration-capability boolean for postcopy-ram.
Add wrappers and handlers for sending/receiving the postcopy-ram
migration messages.
QEMU_VM_CMD_PACKAGED: Send a packaged chunk of migration stream
migrate_init: Call from savevm
Allow savevm handlers to state whether they could go into postcopy
postcopy: OS support test
migrate_start_postcopy: Command to trigger transition to postcopy
MIG_STATE_POSTCOPY_ACTIVE: Add new migration state
qemu_savevm_state_complete: Postcopy changes
Postcopy page-map-incoming (PMI) structure
Postcopy: Maintain sentmap and calculate discard
postcopy: Incoming initialisation
postcopy: ram_enable_notify to switch on userfault
Postcopy: Postcopy startup in migration thread
Postcopy: Create a fault handler thread before marking the ram as
userfault
Page request: Add MIG_RPCOMM_REQPAGES reverse command
Page request: Process incoming page request
Page request: Consume pages off the post-copy queue
Add assertion to check migration_dirty_pages
postcopy_ram.c: place_page and helpers
Postcopy: Use helpers to map pages during migration
qemu_ram_block_from_host
Don't sync dirty bitmaps in postcopy
Host page!=target page: Cleanup bitmaps
Postcopy; Handle userfault requests
Start up a postcopy/listener thread ready for incoming page data
postcopy: Wire up loadvm_postcopy_ram_handle_{run,end} commands
End of migration for postcopy
Makefile.objs | 2 +-
arch_init.c | 739 +++++++++++++++++++++++++--
docs/migration.txt | 189 +++++++
exec.c | 76 ++-
hmp-commands.hx | 15 +
hmp.c | 7 +
hmp.h | 1 +
include/exec/cpu-common.h | 8 +-
include/migration/migration.h | 130 +++++
include/migration/postcopy-ram.h | 106 ++++
include/migration/qemu-file.h | 47 ++
include/migration/vmstate.h | 2 +-
include/qemu/sockets.h | 1 +
include/qemu/typedefs.h | 9 +-
include/sysemu/sysemu.h | 43 +-
migration-fd.c | 24 +-
migration-rdma.c | 4 +-
migration.c | 693 +++++++++++++++++++++++++-
postcopy-ram.c | 1016 ++++++++++++++++++++++++++++++++++++++
qapi-schema.json | 14 +-
qemu-file.c | 598 +++++++++++++++++++++-
qmp-commands.hx | 19 +
savevm.c | 881 +++++++++++++++++++++++++++++++--
tests/Makefile | 2 +-
tests/test-vmstate.c | 74 +--
util/qemu-sockets.c | 28 ++
26 files changed, 4550 insertions(+), 178 deletions(-)
create mode 100644 include/migration/postcopy-ram.h
create mode 100644 postcopy-ram.c
--
1.9.3
next reply other threads:[~2014-10-03 17:48 UTC|newest]
Thread overview: 204+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 17:47 Dr. David Alan Gilbert (git) [this message]
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 01/47] QEMUSizedBuffer based QEMUFile Dr. David Alan Gilbert (git)
2014-10-08 2:10 ` zhanghailiang
2014-11-03 0:53 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 02/47] Tests: QEMUSizedBuffer/QEMUBuffer Dr. David Alan Gilbert (git)
2014-11-03 1:02 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 03/47] Start documenting how postcopy works Dr. David Alan Gilbert (git)
2014-11-03 1:31 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 04/47] qemu_ram_foreach_block: pass up error value, and down the ramblock name Dr. David Alan Gilbert (git)
2014-11-03 2:34 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 05/47] improve DPRINTF macros, add to savevm Dr. David Alan Gilbert (git)
2014-11-03 2:35 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 06/47] Add qemu_get_counted_string to read a string prefixed by a count byte Dr. David Alan Gilbert (git)
2014-11-03 2:39 ` David Gibson
2014-11-25 16:13 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 07/47] Create MigrationIncomingState Dr. David Alan Gilbert (git)
2014-11-03 2:45 ` David Gibson
2014-11-04 19:06 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 08/47] socket shutdown Dr. David Alan Gilbert (git)
2014-10-04 18:09 ` Paolo Bonzini
2014-10-07 10:00 ` Dr. David Alan Gilbert
2014-10-07 11:10 ` Paolo Bonzini
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 09/47] Provide runtime Target page information Dr. David Alan Gilbert (git)
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 10/47] Return path: Open a return path on QEMUFile for sockets Dr. David Alan Gilbert (git)
2014-11-03 3:05 ` David Gibson
2014-11-03 19:04 ` Dr. David Alan Gilbert
2014-11-18 4:34 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 11/47] Return path: socket_writev_buffer: Block even on non-blocking fd's Dr. David Alan Gilbert (git)
2014-11-03 3:10 ` David Gibson
2014-11-03 18:59 ` Dr. David Alan Gilbert
2014-11-18 3:54 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 12/47] Handle bi-directional communication for fd migration Dr. David Alan Gilbert (git)
2014-11-03 3:12 ` David Gibson
2014-11-03 13:53 ` Cristian Klein
2014-11-18 3:53 ` David Gibson
2014-11-19 17:27 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 13/47] Migration commands Dr. David Alan Gilbert (git)
2014-11-03 3:14 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 14/47] Return path: Control commands Dr. David Alan Gilbert (git)
2014-10-04 18:08 ` Paolo Bonzini
2014-10-23 16:23 ` Dr. David Alan Gilbert
2014-10-23 20:15 ` Paolo Bonzini
2014-11-03 3:20 ` David Gibson
2014-11-04 18:58 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 15/47] Return path: Send responses from destination to source Dr. David Alan Gilbert (git)
2014-11-03 3:22 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path Dr. David Alan Gilbert (git)
2014-10-04 18:14 ` Paolo Bonzini
2014-10-23 18:00 ` Dr. David Alan Gilbert
2014-10-24 10:04 ` Paolo Bonzini
2014-10-16 8:26 ` zhanghailiang
2014-10-16 8:35 ` Dr. David Alan Gilbert
2014-10-16 9:09 ` zhanghailiang
2014-11-03 3:47 ` David Gibson
2014-11-25 15:44 ` Dr. David Alan Gilbert
2014-11-03 3:46 ` David Gibson
2014-11-03 13:22 ` Dr. David Alan Gilbert
2014-11-18 3:52 ` David Gibson
2014-11-19 17:06 ` Dr. David Alan Gilbert
2014-11-19 21:12 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 17/47] qemu_loadvm errors and debug Dr. David Alan Gilbert (git)
2014-11-03 3:49 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 18/47] ram_debug_dump_bitmap: Dump a migration bitmap as text Dr. David Alan Gilbert (git)
2014-11-03 3:58 ` David Gibson
2014-11-19 17:35 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops Dr. David Alan Gilbert (git)
2014-10-04 16:46 ` Paolo Bonzini
2014-10-07 8:58 ` Dr. David Alan Gilbert
2014-10-07 10:12 ` Paolo Bonzini
2014-10-07 10:21 ` Dr. David Alan Gilbert
2014-11-03 5:08 ` David Gibson
2014-11-19 17:50 ` Dr. David Alan Gilbert
2014-11-21 6:53 ` David Gibson
2014-12-11 14:47 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 20/47] Add migration-capability boolean for postcopy-ram Dr. David Alan Gilbert (git)
2014-10-06 18:59 ` Eric Blake
2014-10-06 19:07 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 21/47] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages Dr. David Alan Gilbert (git)
2014-11-03 5:51 ` David Gibson
2014-12-17 14:50 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 22/47] QEMU_VM_CMD_PACKAGED: Send a packaged chunk of migration stream Dr. David Alan Gilbert (git)
2014-11-04 1:28 ` David Gibson
2014-11-04 10:19 ` Dr. David Alan Gilbert
2014-11-18 4:36 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 23/47] migrate_init: Call from savevm Dr. David Alan Gilbert (git)
2014-10-08 2:28 ` zhanghailiang
2014-11-04 1:29 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 24/47] Allow savevm handlers to state whether they could go into postcopy Dr. David Alan Gilbert (git)
2014-11-04 1:33 ` David Gibson
2014-11-19 17:53 ` Dr. David Alan Gilbert
2014-11-21 6:58 ` David Gibson
2014-11-25 19:58 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 25/47] postcopy: OS support test Dr. David Alan Gilbert (git)
2014-11-04 1:40 ` David Gibson
2014-11-25 17:34 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 26/47] migrate_start_postcopy: Command to trigger transition to postcopy Dr. David Alan Gilbert (git)
2014-11-04 1:47 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 27/47] MIG_STATE_POSTCOPY_ACTIVE: Add new migration state Dr. David Alan Gilbert (git)
2014-11-04 1:49 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 28/47] qemu_savevm_state_complete: Postcopy changes Dr. David Alan Gilbert (git)
2014-11-04 2:18 ` David Gibson
2014-12-17 16:14 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 29/47] Postcopy page-map-incoming (PMI) structure Dr. David Alan Gilbert (git)
2014-11-04 3:09 ` David Gibson
2014-11-19 18:46 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 30/47] Postcopy: Maintain sentmap and calculate discard Dr. David Alan Gilbert (git)
2014-11-05 6:38 ` David Gibson
2014-12-17 16:48 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 31/47] postcopy: Incoming initialisation Dr. David Alan Gilbert (git)
2014-11-05 6:47 ` David Gibson
2014-12-17 17:21 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 32/47] postcopy: ram_enable_notify to switch on userfault Dr. David Alan Gilbert (git)
2014-10-04 16:42 ` Paolo Bonzini
2014-10-06 19:00 ` Dr. David Alan Gilbert
2014-11-05 6:49 ` David Gibson
2014-11-19 18:59 ` Dr. David Alan Gilbert
2014-11-19 21:17 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 33/47] Postcopy: Postcopy startup in migration thread Dr. David Alan Gilbert (git)
2014-10-04 16:27 ` Paolo Bonzini
2014-11-20 11:45 ` Dr. David Alan Gilbert
2014-11-21 12:01 ` Paolo Bonzini
2014-11-21 12:07 ` Dr. David Alan Gilbert
2014-11-20 17:12 ` Dr. David Alan Gilbert
2014-11-20 17:19 ` Paolo Bonzini
2014-11-24 18:26 ` Dr. David Alan Gilbert
2014-11-10 6:05 ` David Gibson
2015-01-05 16:06 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 34/47] Postcopy: Create a fault handler thread before marking the ram as userfault Dr. David Alan Gilbert (git)
2014-11-10 6:10 ` David Gibson
2014-11-19 18:56 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 35/47] Page request: Add MIG_RPCOMM_REQPAGES reverse command Dr. David Alan Gilbert (git)
2014-11-10 6:19 ` David Gibson
2014-11-19 20:01 ` Dr. David Alan Gilbert
2014-11-19 21:48 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request Dr. David Alan Gilbert (git)
2014-10-08 2:31 ` zhanghailiang
2014-10-08 7:49 ` Dr. David Alan Gilbert
2014-10-08 8:07 ` Paolo Bonzini
2014-10-08 8:10 ` zhanghailiang
2014-10-08 8:18 ` Dr. David Alan Gilbert
2014-11-10 6:31 ` David Gibson
2014-11-17 19:07 ` Dr. David Alan Gilbert
2014-11-18 4:38 ` David Gibson
2014-11-19 19:37 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 37/47] Page request: Consume pages off the post-copy queue Dr. David Alan Gilbert (git)
2014-10-04 18:04 ` Paolo Bonzini
2014-10-07 11:35 ` Dr. David Alan Gilbert
2014-11-11 1:13 ` David Gibson
2015-01-14 20:13 ` Dr. David Alan Gilbert
2015-01-27 4:38 ` David Gibson
2015-01-27 9:40 ` Dr. David Alan Gilbert
2015-01-28 5:33 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 38/47] Add assertion to check migration_dirty_pages Dr. David Alan Gilbert (git)
2014-10-04 18:32 ` Paolo Bonzini
2014-10-06 18:51 ` Dr. David Alan Gilbert
2014-10-06 20:30 ` Paolo Bonzini
2014-11-11 1:14 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 39/47] postcopy_ram.c: place_page and helpers Dr. David Alan Gilbert (git)
2014-11-11 1:39 ` David Gibson
2015-01-15 18:14 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 40/47] Postcopy: Use helpers to map pages during migration Dr. David Alan Gilbert (git)
2014-11-13 2:53 ` David Gibson
2014-11-25 18:14 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 41/47] qemu_ram_block_from_host Dr. David Alan Gilbert (git)
2014-11-13 2:59 ` David Gibson
2014-11-25 18:55 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 42/47] Don't sync dirty bitmaps in postcopy Dr. David Alan Gilbert (git)
2014-11-13 3:01 ` David Gibson
2014-11-25 16:25 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps Dr. David Alan Gilbert (git)
2014-11-13 3:10 ` David Gibson
2014-12-17 18:21 ` Dr. David Alan Gilbert
2015-01-27 4:50 ` David Gibson
2015-01-27 10:04 ` Dr. David Alan Gilbert
2015-01-28 5:36 ` David Gibson
2015-01-27 10:20 ` Peter Maydell
2015-01-27 11:50 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 44/47] Postcopy; Handle userfault requests Dr. David Alan Gilbert (git)
2014-11-13 3:23 ` David Gibson
2015-01-05 17:13 ` Dr. David Alan Gilbert
2015-01-27 4:33 ` David Gibson
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 45/47] Start up a postcopy/listener thread ready for incoming page data Dr. David Alan Gilbert (git)
2014-11-13 3:29 ` David Gibson
2014-11-19 19:40 ` Dr. David Alan Gilbert
2014-11-21 8:36 ` David Gibson
2014-11-21 10:17 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 46/47] postcopy: Wire up loadvm_postcopy_ram_handle_{run, end} commands Dr. David Alan Gilbert (git)
2014-10-04 17:51 ` Paolo Bonzini
2014-10-23 12:18 ` Dr. David Alan Gilbert
2014-10-03 17:47 ` [Qemu-devel] [PATCH v4 47/47] End of migration for postcopy Dr. David Alan Gilbert (git)
2014-10-04 17:49 ` Paolo Bonzini
2014-10-23 14:24 ` Dr. David Alan Gilbert
2014-10-04 18:31 ` Paolo Bonzini
2014-10-07 10:29 ` Dr. David Alan Gilbert
2014-10-07 11:12 ` Paolo Bonzini
2014-10-03 19:21 ` [Qemu-devel] [PATCH v4 00/47] Postcopy implementation Dr. David Alan Gilbert
2014-10-07 2:27 ` Cristian Klein
2014-10-07 8:12 ` Dr. David Alan Gilbert
2014-10-08 8:36 ` Cristian Klein
2014-11-21 3:48 ` zhanghailiang
2014-11-21 10:14 ` Dr. David Alan Gilbert
2014-11-24 8:10 ` zhanghailiang
2014-11-21 18:56 ` Andrea Arcangeli
2014-11-24 8:25 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412358473-31398-1-git-send-email-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=aarcange@redhat.com \
--cc=amit.shah@redhat.com \
--cc=cristian.klein@cs.umu.se \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yamahata@private.email.ne.jp \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).