From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaVtd-0006HU-SS for qemu-devel@nongnu.org; Sat, 04 Oct 2014 16:25:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaVtX-0004lL-O4 for qemu-devel@nongnu.org; Sat, 04 Oct 2014 16:25:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaVtX-0004lC-BA for qemu-devel@nongnu.org; Sat, 04 Oct 2014 16:25:35 -0400 From: Stefan Hajnoczi Date: Sat, 4 Oct 2014 21:24:46 +0100 Message-Id: <1412454289-1789-21-git-send-email-stefanha@redhat.com> In-Reply-To: <1412454289-1789-1-git-send-email-stefanha@redhat.com> References: <1412454289-1789-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 20/23] blockdev-test: Clean up bogus drive_add argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell From: Markus Armbruster The first argument should be a PCI address, which pci-addr=auto isn't. Doesn't really matter, as drive_add ignores its first argument when its second argument has if=none. Clean it up anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1412261496-24455-4-git-send-email-armbru@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/drive_del-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c index a5de239..32516a2 100644 --- a/tests/drive_del-test.c +++ b/tests/drive_del-test.c @@ -83,7 +83,7 @@ static void test_after_failed_device_add(void) */ response = qmp("{'execute': 'human-monitor-command'," " 'arguments': {" - " 'command-line': 'drive_add pci-addr=auto if=none,id=drive0'" + " 'command-line': 'drive_add 0 if=none,id=drive0'" "}}"); g_assert(response); g_assert_cmpstr(qdict_get_try_str(response, "return"), ==, "OK\r\n"); -- 1.9.3