qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Cedric Sodhi <ManDay@gmx.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Fullscreen Bug with GTK
Date: Mon, 06 Oct 2014 12:28:22 +0200	[thread overview]
Message-ID: <1412591302.5003.22.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <trinity-518be1c3-a182-4a74-9aea-479b96a4fcc3-1412590489735@3capp-gmx-bs49>

On Mo, 2014-10-06 at 12:14 +0200, Cedric Sodhi wrote:
> > > https://bugs.launchpad.net/qemu/+bug/1294898
> > >
> > > A patch was provided by the initial reporter a long time ago.
> > 
> > Patch trades one bug for another. Hiding the menu bar also kills the
> > accelerator keys, which is especially problematic for the fullscreen
> > hotkey as there is no way out of fullscreen mode then.
> 
> How do you come to that conclusion?

I've tried to fix that before, without success.

> The reporter explicitly mentioned that removing the Menu disables the
> Accels and therefore he has provided a patch which attaches the Accels
> to the Window instead (which, in fact, is how it should be done).

Oh, missed that detail.  /me recommends submitting the patches to
qemu-devel then (and cc me so I don't miss them).

cheers,
  Gerd

  reply	other threads:[~2014-10-06 10:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-04  8:18 [Qemu-devel] Fullscreen Bug with GTK Cedric Sodhi
2014-10-06  8:06 ` Gerd Hoffmann
2014-10-06  9:14   ` Dr. David Alan Gilbert
2014-10-06  9:40     ` Gerd Hoffmann
2014-10-06 10:14   ` Cedric Sodhi
2014-10-06 10:28     ` Gerd Hoffmann [this message]
2014-10-06 11:24       ` Peter Maydell
2014-10-06 12:00         ` Cedric Sodhi
2014-10-09 17:30         ` Cole Robinson
2014-10-09 20:13           ` Cedric Sodhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412591302.5003.22.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=ManDay@gmx.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).