From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, benoit.canet@nodalink.com, stefanha@redhat.com,
mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v6 24/24] block: Make device model's references to BlockBackend strong
Date: Tue, 7 Oct 2014 13:59:26 +0200 [thread overview]
Message-ID: <1412683166-4934-25-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1412683166-4934-1-git-send-email-armbru@redhat.com>
Doesn't make a difference just yet, but it's the right thing to do.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/block-backend.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index bdcbac6..d0692b1 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -257,6 +257,7 @@ int blk_attach_dev(BlockBackend *blk, void *dev)
if (blk->dev) {
return -EBUSY;
}
+ blk_ref(blk);
blk->dev = dev;
bdrv_iostatus_reset(blk->bs);
@@ -290,6 +291,7 @@ void blk_detach_dev(BlockBackend *blk, void *dev)
blk->dev_opaque = NULL;
bdrv_set_guest_block_size(blk->bs, 512);
qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION);
+ blk_unref(blk);
}
/*
--
1.9.3
next prev parent reply other threads:[~2014-10-07 11:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 11:59 [Qemu-devel] [PATCH v6 00/24] Split BlockBackend off BDS with an axe Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 01/24] block: Split bdrv_new_root() off bdrv_new() Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 02/24] block: New BlockBackend Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 03/24] block: Connect BlockBackend to BlockDriverState Markus Armbruster
2014-10-07 15:51 ` Max Reitz
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 04/24] block: Connect BlockBackend and DriveInfo Markus Armbruster
2014-10-07 15:59 ` Max Reitz
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 05/24] block: Code motion to get rid of stubs/blockdev.c Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 06/24] block: Make BlockBackend own its BlockDriverState Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 07/24] blockdev: Eliminate drive_del() Markus Armbruster
2014-10-07 16:04 ` Max Reitz
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 08/24] block: Eliminate bdrv_iterate(), use bdrv_next() Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 09/24] block: Eliminate BlockDriverState member device_name[] Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 10/24] block: Merge BlockBackend and BlockDriverState name spaces Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 11/24] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo() Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 12/24] block: Rename BlockDriverAIOCB* to BlockAIOCB* Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 13/24] block: Rename BlockDriverCompletionFunc to BlockCompletionFunc Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 14/24] virtio-blk: Drop redundant VirtIOBlock member conf Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 15/24] virtio-blk: Rename VirtIOBlkConf variables to conf Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 16/24] hw: Convert from BlockDriverState to BlockBackend, mostly Markus Armbruster
2014-10-07 16:10 ` Max Reitz
2014-10-17 18:31 ` Kevin Wolf
2014-10-20 8:19 ` Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 17/24] ide: Complete conversion from BlockDriverState to BlockBackend Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 18/24] pc87312: Drop unused members of PC87312State Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 19/24] blockdev: Drop superfluous DriveInfo member id Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 20/24] blockdev: Fix blockdev-add not to create DriveInfo Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 21/24] block/qapi: Convert qmp_query_block() to BlockBackend Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 22/24] blockdev: Convert qmp_eject(), qmp_change_blockdev() " Markus Armbruster
2014-10-07 11:59 ` [Qemu-devel] [PATCH v6 23/24] block: Lift device model API into BlockBackend Markus Armbruster
2014-10-07 11:59 ` Markus Armbruster [this message]
2014-10-17 19:07 ` [Qemu-devel] [PATCH v6 00/24] Split BlockBackend off BDS with an axe Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412683166-4934-25-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).