qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Felipe Franciosi" <felipe@nutanix.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"changpeng liu" <changpeng.liu@intel.com>
Subject: Re: [Qemu-devel] [PULL 00/27] vhost-user patches
Date: Tue, 10 Oct 2017 13:42:13 -0400 (EDT)	[thread overview]
Message-ID: <1412741304.28261373.1507657333058.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAFEAcA8d+UkhOJKovyedTye=8mD0mcbEScHm58RKyCuzYezxqA@mail.gmail.com>

Hi

----- Original Message -----
> On 10 October 2017 at 18:10, Marc-André Lureau
> <marcandre.lureau@redhat.com> wrote:
> > The following changes since commit
> > 567d0a19c7998fa366598b83d5a6e5f0759d3ea9:
> >
> >   Merge remote-tracking branch
> >   'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging
> >   (2017-10-10 13:25:46 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/elmarco/qemu.git tags/vus-pull-request
> >
> > for you to fetch changes up to 25f1fe82c64c8c4922254d63195e1d9cffbb0507:
> >
> >   vhost-user-scsi: remove server_sock from VusDev (2017-10-10 19:06:06
> >   +0200)
> >
> > ----------------------------------------------------------------
> >
> > ----------------------------------------------------------------
> 
> Hi. I'm afraid this fails to build:
> 
> On ppc host:
>   CC      contrib/libvhost-user/libvhost-user.o
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function
> ‘vu_set_vring_addr_exec’:
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:524:5: error:
> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
> argument 3 has type ‘__u64’ [-Werror=format=]
>      DPRINT("    desc_user_addr:   0x%016llx\n", vra->desc_user_addr);
>      ^
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:525:5: error:
> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
> argument 3 has type ‘__u64’ [-Werror=format=]
>      DPRINT("    used_user_addr:   0x%016llx\n", vra->used_user_addr);
>      ^
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:526:5: error:
> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
> argument 3 has type ‘__u64’ [-Werror=format=]
>      DPRINT("    avail_user_addr:  0x%016llx\n", vra->avail_user_addr);
>      ^
> /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:527:5: error:
> format ‘%llx’ expects argument of type ‘long long unsigned int’, but
> argument 3 has type ‘__u64’ [-Werror=format=]
>      DPRINT("    log_guest_addr:   0x%016llx\n", vra->log_guest_addr);
>      ^
> 
> 
> On NetBSD, OpenBSD, FreeBSD, OSX:
> 
>   CC      contrib/libvhost-user/libvhost-user.o
> /root/qemu/contrib/libvhost-user/libvhost-user.c:27:25: fatal error:
> sys/eventfd.h: No such file or directory
>  #include <sys/eventfd.h>
>                          ^
> compilation terminated.
> 

That was quick!

It looks like the solution is to remove libvhost-user.a from $(SUBDIR_RULES) target. I have checked with 'make vm-build-freebsd'.

(the printf format errors are pre-existing - I think should be addressed in a different series) 

  reply	other threads:[~2017-10-10 17:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 17:10 [Qemu-devel] [PULL 00/27] vhost-user patches Marc-André Lureau
2017-10-10 17:10 ` [Qemu-devel] [PULL 01/27] glib-compat: move G_SOURCE_CONTINUE/REMOVE there Marc-André Lureau
2017-10-10 17:10 ` [Qemu-devel] [PULL 02/27] build-sys: fix libvhost-user.a build Marc-André Lureau
2017-10-10 17:10 ` [Qemu-devel] [PULL 03/27] build-sys: make vhost-user-scsi depend on libvhost-user.a Marc-André Lureau
2017-10-10 17:10 ` [Qemu-devel] [PULL 04/27] libvhost-user: drop dependency on glib Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 05/27] libvhost-user: improve vu_queue_pop() doc Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 06/27] vhost-user-scsi: use g_strdup() Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 07/27] vhost-user-scsi: connect unix socket before allocating Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 08/27] vhost-user-scsi: code style fixes Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 09/27] vhost-user-scsi: use glib allocation Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 10/27] vhost-user-scsi: glib calls that allocate don't return NULL Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 11/27] vhost-user-scsi: also free the gtree Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 12/27] vhost-user-scsi: remove vdev_scsi_find_by_vu() Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 13/27] vhost-user-scsi: simplify unix path cleanup Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 14/27] vhost-user-scsi: use NULL pointer Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 15/27] vhost-user-scsi: assert() in iscsi_add_lun() Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 16/27] vhost-user-scsi: remove vdev_scsi_add_iscsi_lun() Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 17/27] vhost-user-scsi: remove VUS_MAX_LUNS Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 18/27] vhost-user-scsi: remove unimplemented functions Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 19/27] vhost-user-scsi: rename VUS types Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 20/27] vhost-user-scsi: avoid use of iscsi_ namespace Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 21/27] vhost-user-scsi: don't copy iscsi/scsi-lowlevel.h Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 22/27] vhost-user-scsi: drop extra callback pointer Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 23/27] vhost-user-scsi: simplify source handling Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 24/27] vhost-user-scsi: use glib logging Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 25/27] libvhost-user: add glib source helper Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 26/27] vhost-user-scsi: use libvhost-user glib helper Marc-André Lureau
2017-10-10 17:11 ` [Qemu-devel] [PULL 27/27] vhost-user-scsi: remove server_sock from VusDev Marc-André Lureau
2017-10-10 17:22 ` [Qemu-devel] [PULL 00/27] vhost-user patches Peter Maydell
2017-10-10 17:42   ` Marc-André Lureau [this message]
2017-10-10 17:43     ` Peter Maydell
2017-10-10 18:23     ` Kamil Rytarowski
2017-10-10 17:53   ` Peter Maydell
2017-10-10 21:03 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412741304.28261373.1507657333058.JavaMail.zimbra@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=changpeng.liu@intel.com \
    --cc=f4bug@amsat.org \
    --cc=felipe@nutanix.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).