* [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4
@ 2014-10-10 10:23 Paolo Bonzini
2014-10-10 11:20 ` Christian Borntraeger
2014-10-10 13:55 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2014-10-10 10:23 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
As usual, SLES11's GCC complained about double typedefs:
/home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’
/home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration of ‘KVMState’ was here
Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
kvm-all.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index e98a7c7..44a5e72 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -71,7 +71,7 @@ typedef struct KVMSlot
typedef struct kvm_dirty_log KVMDirtyLog;
-typedef struct KVMState
+struct KVMState
{
AccelState parent_obj;
@@ -107,7 +107,7 @@ typedef struct KVMState
QTAILQ_HEAD(msi_hashtab, KVMMSIRoute) msi_hashtab[KVM_MSI_HASHTAB_SIZE];
bool direct_msi;
#endif
-} KVMState;
+};
#define TYPE_KVM_ACCEL ACCEL_CLASS_NAME("kvm")
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4
2014-10-10 10:23 [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4 Paolo Bonzini
@ 2014-10-10 11:20 ` Christian Borntraeger
2014-10-10 13:55 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2014-10-10 11:20 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: peter.maydell
Am 10.10.2014 12:23, schrieb Paolo Bonzini:
> As usual, SLES11's GCC complained about double typedefs:
RHEL 6.5 gcc 4.4.7 complains as well. :-)
This fix helps there as well.
>
> /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’
> /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration of ‘KVMState’ was here
>
> Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> kvm-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index e98a7c7..44a5e72 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -71,7 +71,7 @@ typedef struct KVMSlot
>
> typedef struct kvm_dirty_log KVMDirtyLog;
>
> -typedef struct KVMState
> +struct KVMState
> {
> AccelState parent_obj;
>
> @@ -107,7 +107,7 @@ typedef struct KVMState
> QTAILQ_HEAD(msi_hashtab, KVMMSIRoute) msi_hashtab[KVM_MSI_HASHTAB_SIZE];
> bool direct_msi;
> #endif
> -} KVMState;
> +};
>
> #define TYPE_KVM_ACCEL ACCEL_CLASS_NAME("kvm")
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4
2014-10-10 10:23 [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4 Paolo Bonzini
2014-10-10 11:20 ` Christian Borntraeger
@ 2014-10-10 13:55 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2014-10-10 13:55 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On 10 October 2014 11:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
> As usual, SLES11's GCC complained about double typedefs:
>
> /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’
> /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration of ‘KVMState’ was here
>
> Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-10 13:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 10:23 [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4 Paolo Bonzini
2014-10-10 11:20 ` Christian Borntraeger
2014-10-10 13:55 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).