From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33096)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Xcglz-0007JF-Mc
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 16:26:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Xcglm-00013j-Ok
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 16:26:47 -0400
Received: from gate.crashing.org ([63.228.1.57]:60025)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Xcglm-000135-GK
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 16:26:34 -0400
Message-ID: <1412972775.30859.325.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sat, 11 Oct 2014 07:26:15 +1100
In-Reply-To: <1412970269-21120-1-git-send-email-peter.maydell@linaro.org>
References: <1412970269-21120-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/display/vga: Remove unused arrays
	dmask4 and dmask16
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: David Gibson <david@gibson.dropbear.id.au>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org, patches@linaro.org

On Fri, 2014-10-10 at 20:44 +0100, Peter Maydell wrote:
> Following cleanup of the vga device code in commit d2e043a8041,
> the arrays dmask4 and dmask16 are now unused. gcc doesn't warn
> about this, but clang does; remove them.

Ah right, I missed those, thanks.

> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/display/vga.c | 26 --------------------------
>  1 file changed, 26 deletions(-)
> 
> diff --git a/hw/display/vga.c b/hw/display/vga.c
> index 19e7f23..52eaf05 100644
> --- a/hw/display/vga.c
> +++ b/hw/display/vga.c
> @@ -136,32 +136,6 @@ static const uint32_t mask16[16] = {
>  #define PAT(x) cbswap_32(x)
>  #endif
>  
> -static const uint32_t dmask16[16] = {
> -    PAT(0x00000000),
> -    PAT(0x000000ff),
> -    PAT(0x0000ff00),
> -    PAT(0x0000ffff),
> -    PAT(0x00ff0000),
> -    PAT(0x00ff00ff),
> -    PAT(0x00ffff00),
> -    PAT(0x00ffffff),
> -    PAT(0xff000000),
> -    PAT(0xff0000ff),
> -    PAT(0xff00ff00),
> -    PAT(0xff00ffff),
> -    PAT(0xffff0000),
> -    PAT(0xffff00ff),
> -    PAT(0xffffff00),
> -    PAT(0xffffffff),
> -};
> -
> -static const uint32_t dmask4[4] = {
> -    PAT(0x00000000),
> -    PAT(0x0000ffff),
> -    PAT(0xffff0000),
> -    PAT(0xffffffff),
> -};
> -
>  static uint32_t expand4[256];
>  static uint16_t expand2[256];
>  static uint8_t expand4to8[16];