From: Gerd Hoffmann <kraxel@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Intel.Product.Security.Incident.Response.Team@intel.com,
pmatouse@redhat.com, qemu-devel@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect
Date: Tue, 14 Oct 2014 12:08:22 +0200 [thread overview]
Message-ID: <1413281302.3199.9.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <alpine.LMD.2.02.1410141126051.13267@jedlik.phy.bme.hu>
On Di, 2014-10-14 at 11:29 +0200, BALATON Zoltan wrote:
> On Tue, 14 Oct 2014, Gerd Hoffmann wrote:
> > Switch vmsvga_update_rect over to use vmsvga_verify_rect. Slight change
> > in behavior: We don't try to automatically fixup rectangles any more.
> > Invalid update requests will be ignored instead.
>
> Are you sure this won't break clients? I remember that maybe Windows
> drivers did produce requests with partially off screen rectangles for
> objects that are partially visible. I don't recall if this was for windows
> dragged off screen or mouse pointer near the screen but there was a reason
> this fixup was added. Did you test this?
Not tested. I don't have windows guests with vmware drivers. The
fixups avoid qemu crashing for sure. Possibly they are also needed to
prevent rendering problems. Should that be the case I'd tend to simply
do a full-screen refresh as fallback should we see invalid rectangles
instead of keeping the fixup logic. The fixups become quite complex for
the bitblit case, thats why I dropped them.
cheers,
Gerd
next prev parent reply other threads:[~2014-10-14 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 7:45 [Qemu-devel] [PATCH 0/5] vmware-vga: fix CVE-2014-3689 Gerd Hoffmann
2014-10-14 7:45 ` [Qemu-devel] [PATCH 1/5] vmware-vga: CVE-2014-3689: turn off hw accel Gerd Hoffmann
2014-10-14 7:45 ` [Qemu-devel] [PATCH 2/5] vmware-vga: add vmsvga_verify_rect Gerd Hoffmann
2014-10-14 9:24 ` Gonglei
2014-10-14 7:45 ` [Qemu-devel] [PATCH 3/5] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect Gerd Hoffmann
2014-10-14 9:29 ` BALATON Zoltan
2014-10-14 10:08 ` Gerd Hoffmann [this message]
2014-10-14 7:45 ` [Qemu-devel] [PATCH 4/5] vmware-vga: use vmsvga_verify_rect in vmsvga_copy_rect Gerd Hoffmann
2014-10-14 7:45 ` [Qemu-devel] [PATCH 5/5] vmware-vga: use vmsvga_verify_rect in vmsvga_fill_rect Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413281302.3199.9.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=Intel.Product.Security.Incident.Response.Team@intel.com \
--cc=balaton@eik.bme.hu \
--cc=pmatouse@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).