From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xdz21-0003We-Ch for qemu-devel@nongnu.org; Tue, 14 Oct 2014 06:08:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xdz1u-0002pY-Sz for qemu-devel@nongnu.org; Tue, 14 Oct 2014 06:08:41 -0400 Message-ID: <1413281302.3199.9.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 14 Oct 2014 12:08:22 +0200 In-Reply-To: References: <1413272710-10458-1-git-send-email-kraxel@redhat.com> <1413272710-10458-4-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/5] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: Intel.Product.Security.Incident.Response.Team@intel.com, pmatouse@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org On Di, 2014-10-14 at 11:29 +0200, BALATON Zoltan wrote: > On Tue, 14 Oct 2014, Gerd Hoffmann wrote: > > Switch vmsvga_update_rect over to use vmsvga_verify_rect. Slight change > > in behavior: We don't try to automatically fixup rectangles any more. > > Invalid update requests will be ignored instead. > > Are you sure this won't break clients? I remember that maybe Windows > drivers did produce requests with partially off screen rectangles for > objects that are partially visible. I don't recall if this was for windows > dragged off screen or mouse pointer near the screen but there was a reason > this fixup was added. Did you test this? Not tested. I don't have windows guests with vmware drivers. The fixups avoid qemu crashing for sure. Possibly they are also needed to prevent rendering problems. Should that be the case I'd tend to simply do a full-screen refresh as fallback should we see invalid rectangles instead of keeping the fixup logic. The fixups become quite complex for the bitblit case, thats why I dropped them. cheers, Gerd