* [Qemu-devel] AArch64: duplicate store in do_fp_st
@ 2014-10-11 16:32 Laurent Desnogues
2014-10-14 13:08 ` [Qemu-devel] [PATCH] target-arm: A64: remove redundant store Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Desnogues @ 2014-10-11 16:32 UTC (permalink / raw)
To: qemu-devel@nongnu.org, Peter Maydell
Hello,
in target-arm/translate-a64.c:do_fp_st, it looks like there's an
extraneous store:
TCGv_i64 tcg_hiaddr = tcg_temp_new_i64();
tcg_gen_qemu_st_i64(tmp, tcg_addr, get_mem_index(s), MO_TEQ);
tcg_gen_qemu_st64(tmp, tcg_addr, get_mem_index(s));
The second one can safely be removed.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] target-arm: A64: remove redundant store
2014-10-11 16:32 [Qemu-devel] AArch64: duplicate store in do_fp_st Laurent Desnogues
@ 2014-10-14 13:08 ` Alex Bennée
2014-10-14 14:07 ` Laurent Desnogues
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2014-10-14 13:08 UTC (permalink / raw)
To: qemu-devel; +Cc: laurent.desnogues, peter.maydell, Alex Bennée
There is not much point storing the same value twice in a row.
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
target-arm/translate-a64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index 35ae3ea..337f4d4 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -748,7 +748,6 @@ static void do_fp_st(DisasContext *s, int srcidx, TCGv_i64 tcg_addr, int size)
} else {
TCGv_i64 tcg_hiaddr = tcg_temp_new_i64();
tcg_gen_qemu_st_i64(tmp, tcg_addr, get_mem_index(s), MO_TEQ);
- tcg_gen_qemu_st64(tmp, tcg_addr, get_mem_index(s));
tcg_gen_ld_i64(tmp, cpu_env, fp_reg_hi_offset(s, srcidx));
tcg_gen_addi_i64(tcg_hiaddr, tcg_addr, 8);
tcg_gen_qemu_st_i64(tmp, tcg_hiaddr, get_mem_index(s), MO_TEQ);
--
2.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: A64: remove redundant store
2014-10-14 13:08 ` [Qemu-devel] [PATCH] target-arm: A64: remove redundant store Alex Bennée
@ 2014-10-14 14:07 ` Laurent Desnogues
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Desnogues @ 2014-10-14 14:07 UTC (permalink / raw)
To: Alex Bennée; +Cc: Peter Maydell, qemu-devel@nongnu.org
On Tue, Oct 14, 2014 at 3:08 PM, Alex Bennée <alex.bennee@linaro.org> wrote:
> There is not much point storing the same value twice in a row.
>
> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Thanks,
Laurent
> ---
> target-arm/translate-a64.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 35ae3ea..337f4d4 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -748,7 +748,6 @@ static void do_fp_st(DisasContext *s, int srcidx, TCGv_i64 tcg_addr, int size)
> } else {
> TCGv_i64 tcg_hiaddr = tcg_temp_new_i64();
> tcg_gen_qemu_st_i64(tmp, tcg_addr, get_mem_index(s), MO_TEQ);
> - tcg_gen_qemu_st64(tmp, tcg_addr, get_mem_index(s));
> tcg_gen_ld_i64(tmp, cpu_env, fp_reg_hi_offset(s, srcidx));
> tcg_gen_addi_i64(tcg_hiaddr, tcg_addr, 8);
> tcg_gen_qemu_st_i64(tmp, tcg_hiaddr, get_mem_index(s), MO_TEQ);
> --
> 2.1.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] target-arm: A64: remove redundant store
@ 2014-10-15 7:16 Alex Bennée
0 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2014-10-15 7:16 UTC (permalink / raw)
To: qemu-trivial; +Cc: Peter Maydell, Alex Bennée, qemu-devel
There is not much point storing the same value twice in a row.
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
---
target-arm/translate-a64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index 35ae3ea..337f4d4 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -748,7 +748,6 @@ static void do_fp_st(DisasContext *s, int srcidx, TCGv_i64 tcg_addr, int size)
} else {
TCGv_i64 tcg_hiaddr = tcg_temp_new_i64();
tcg_gen_qemu_st_i64(tmp, tcg_addr, get_mem_index(s), MO_TEQ);
- tcg_gen_qemu_st64(tmp, tcg_addr, get_mem_index(s));
tcg_gen_ld_i64(tmp, cpu_env, fp_reg_hi_offset(s, srcidx));
tcg_gen_addi_i64(tcg_hiaddr, tcg_addr, 8);
tcg_gen_qemu_st_i64(tmp, tcg_hiaddr, get_mem_index(s), MO_TEQ);
--
2.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-15 7:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-11 16:32 [Qemu-devel] AArch64: duplicate store in do_fp_st Laurent Desnogues
2014-10-14 13:08 ` [Qemu-devel] [PATCH] target-arm: A64: remove redundant store Alex Bennée
2014-10-14 14:07 ` Laurent Desnogues
-- strict thread matches above, loose matches on Subject: below --
2014-10-15 7:16 Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).