From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeEy5-00066l-AY for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeExv-0004oU-FM for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49336 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeExv-0004nz-8q for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:31 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 15 Oct 2014 05:08:59 +0200 Message-Id: <1413342561-4754-26-git-send-email-afaerber@suse.de> In-Reply-To: <1413342561-4754-1-git-send-email-afaerber@suse.de> References: <1413342561-4754-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 25/47] virtio-pci: Drop BusState::allow_hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Anthony Liguori , "Michael S. Tsirkin" From: Igor Mammedov virtio-pci-bus is an internal object of composite virtio-pci device and it doesn't participate in -device/device_add hotplug flow, and since it's not required by bus_add_child() that BUS must be hotpluggable to be able to add child at runtime, it's possible to drop not needed 'allow_hotplug' field. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas F=C3=A4rber --- hw/virtio/virtio-pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 390f824..10abd65 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1542,13 +1542,10 @@ static void virtio_pci_bus_new(VirtioBusState *bu= s, size_t bus_size, VirtIOPCIProxy *dev) { DeviceState *qdev =3D DEVICE(dev); - BusState *qbus; char virtio_bus_name[] =3D "virtio-bus"; =20 qbus_create_inplace(bus, bus_size, TYPE_VIRTIO_PCI_BUS, qdev, virtio_bus_name); - qbus =3D BUS(bus); - qbus->allow_hotplug =3D 1; } =20 static void virtio_pci_bus_class_init(ObjectClass *klass, void *data) --=20 1.8.4.5