From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeEyB-0006H6-Pf for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeEy0-0004t6-95 for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49366 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeEy0-0004sV-3U for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:36 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 15 Oct 2014 05:09:10 +0200 Message-Id: <1413342561-4754-37-git-send-email-afaerber@suse.de> In-Reply-To: <1413342561-4754-1-git-send-email-afaerber@suse.de> References: <1413342561-4754-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 36/47] usb-bot: Drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Gerd Hoffmann From: Igor Mammedov Drop useless hack that disables hotplug on bus by setting "allow_hotplug =3D 0". Even if bus is hotpluggable, It won't be possible to add another SCSI device to bus since its realization will fail early with error "no free target" in scsi_qdev_realize() method. Signed-off-by: Igor Mammedov Signed-off-by: Andreas F=C3=A4rber --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index a207507..bccaa3f 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -653,7 +653,6 @@ static void usb_msd_realize_bot(USBDevice *dev, Error= **errp) usb_desc_init(dev); scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(dev), &usb_msd_scsi_info_bot, NULL); - s->bus.qbus.allow_hotplug =3D 0; usb_msd_handle_reset(dev); } =20 --=20 1.8.4.5