From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeEyC-0006Hq-4p for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeEy0-0004tb-Mo for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49357 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeEy0-0004r4-7k for qemu-devel@nongnu.org; Tue, 14 Oct 2014 23:09:36 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 15 Oct 2014 05:09:11 +0200 Message-Id: <1413342561-4754-38-git-send-email-afaerber@suse.de> In-Reply-To: <1413342561-4754-1-git-send-email-afaerber@suse.de> References: <1413342561-4754-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 37/47] usb-storage: Drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Gerd Hoffmann From: Igor Mammedov Drop useless hack that disables hotplug on bus, after backend storage was added to it, by setting "allow_hotplug =3D 0". Even if bus is hotpluggable, it won't be possible to add another SCSI device to bus since its realize will fail early with error "no free target" in scsi_qdev_realize() method. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas F=C3=A4rber --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index bccaa3f..b005783 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, E= rror **errp) error_propagate(errp, err); return; } - s->bus.qbus.allow_hotplug =3D 0; usb_msd_handle_reset(dev); =20 if (bdrv_key_required(bs)) { --=20 1.8.4.5