Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec include file

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> +/* VIRTIO_GPU_RESP_OK_DISPLAY_INFO */
> +#define VIRTIO_GPU_MAX_SCANOUTS 16
> +struct virtio_gpu_resp_display_info {
> +    struct virtio_gpu_ctrl_hdr hdr;
> +    struct virtio_gpu_display_one {
> +        uint32_t enabled;
> +        uint32_t width;
> +        uint32_t height;
> +        uint32_t x;
> +        uint32_t y;
> +        uint32_t flags;
> +    } pmodes[VIRTIO_GPU_MAX_SCANOUTS];

One more thing: I think it would be a good idea to add the display
resolution here.  We start seeing highres displays on desktops, and the
guest should know whenever the host display runs at 100 or 300 dpi ...

What do you think?

cheers,
  Gerd