From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XeLSP-0000zM-QZ
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 06:05:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XeLSJ-0004Ya-L3
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 06:05:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49866)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XeLSJ-0004YT-6m
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 06:05:19 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9FA5IQQ005591
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 15 Oct 2014 06:05:18 -0400
Message-ID: <1413367516.4213.1.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 15 Oct 2014 12:05:16 +0200
In-Reply-To: <1411478887-15183-2-git-send-email-kraxel@redhat.com>
References: <1411478887-15183-1-git-send-email-kraxel@redhat.com>
	<1411478887-15183-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec
	include file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Dave Airlie <airlied@redhat.com>

  Hi,

> +/* VIRTIO_GPU_RESP_OK_DISPLAY_INFO */
> +#define VIRTIO_GPU_MAX_SCANOUTS 16
> +struct virtio_gpu_resp_display_info {
> +    struct virtio_gpu_ctrl_hdr hdr;
> +    struct virtio_gpu_display_one {
> +        uint32_t enabled;
> +        uint32_t width;
> +        uint32_t height;
> +        uint32_t x;
> +        uint32_t y;
> +        uint32_t flags;
> +    } pmodes[VIRTIO_GPU_MAX_SCANOUTS];

One more thing: I think it would be a good idea to add the display
resolution here.  We start seeing highres displays on desktops, and the
guest should know whenever the host display runs at 100 or 300 dpi ...

What do you think?

cheers,
  Gerd