From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeLYt-0003ZD-Gr for qemu-devel@nongnu.org; Wed, 15 Oct 2014 06:12:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeLYo-00072h-Fn for qemu-devel@nongnu.org; Wed, 15 Oct 2014 06:12:07 -0400 From: Gerd Hoffmann Date: Wed, 15 Oct 2014 12:10:39 +0200 Message-Id: <1413367839-30999-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1413367839-30999-1-git-send-email-kraxel@redhat.com> References: <1413367839-30999-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH v2 5/5] vmware-vga: use vmsvga_verify_rect in vmsvga_fill_rect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, pmatouse@redhat.com, Intel.Product.Security.Incident.Response.Team@intel.com, Gerd Hoffmann Add verification to vmsvga_fill_rect, re-enable HW_FILL_ACCEL. Cc: qemu-stable@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/display/vmware_vga.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 1fc9641..7f3a9e6 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -30,9 +30,7 @@ #undef VERBOSE #define HW_RECT_ACCEL -#if 0 #define HW_FILL_ACCEL -#endif #define HW_MOUSE_ACCEL #include "vga_int.h" @@ -456,6 +454,10 @@ static inline void vmsvga_fill_rect(struct vmsvga_state_s *s, uint8_t *src; uint8_t col[4]; + if (!vmsvga_verify_rect(surface, __func__, x, y, w, h)) { + return; + } + col[0] = c; col[1] = c >> 8; col[2] = c >> 16; -- 1.8.3.1