From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XePaO-0004nV-C4
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 10:30:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XePaI-00055S-6B
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 10:29:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4102)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XePaH-00055O-V7
	for qemu-devel@nongnu.org; Wed, 15 Oct 2014 10:29:50 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9FETnvI007222
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 15 Oct 2014 10:29:49 -0400
Message-ID: <1413383387.4213.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 15 Oct 2014 16:29:47 +0200
In-Reply-To: <20141015123237.GB3741@redhat.com>
References: <1413375585-20301-1-git-send-email-kraxel@redhat.com>
	<20141015123237.GB3741@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] vnc: add support for multiple vnc
 server instances.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

> > To be done: monitor support.  I think the best way to handle this is to
> > introduce a new command to query vnc server state, which returns a list
> > of vnc servers but otherwise works like "query-vnc".  Alternative
> > approach would be to add a optional 'id=' parameter to query-vnc, but
> > then you'll need a new list-vnc command.
> > 
> > Opinions on this?
> 
> I don't think it makes a whole lot of difference really. Either way
> mgmt apps like libvirt will need updating to deal with the new monitor
> commands.

One thing that comes do mind is that if we do a completely new command
we can easily fix any shortcomings of the existing query-vnc command.

The listening address could be changed to be a *list* of addresses,
allowing to notify libvirt about multiple listening sockets.  One ipv4,
one ipv6 being a use case.

If someone has more issues / suggestions I'd be happy to hear about
them.

cheers,
  Gerd