From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57189)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xg6ze-0006Sq-LC
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 03:03:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xg6zY-0002Uh-IO
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 03:03:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6450)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xg6zY-0002UU-Bq
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 03:02:56 -0400
Message-ID: <1413788563.3509.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 20 Oct 2014 09:02:43 +0200
In-Reply-To: <5440B85F.3060307@huawei.com>
References: <1413375585-20301-1-git-send-email-kraxel@redhat.com>
	<1413375585-20301-7-git-send-email-kraxel@redhat.com>
	<20141015123110.GA3741@redhat.com>
	<1413382769.4213.5.camel@nilsson.home.kraxel.org>
	<20141015143915.GE3741@redhat.com>
	<1413456389.18160.1.camel@nilsson.home.kraxel.org>
	<5440B85F.3060307@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/6] vnc: track & limit connections
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gonglei <arei.gonglei@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>


  Hi,

> If we set the max trying times, and then
> There are some concepts:
>  - INTERVAL_TIME: a time window that user can connnet vnc server
>  - REJECT_TIME: the time of reject any connection
>  - MAX_TRY_TIMES: the times that user can connect vnc server in INTERVAL_TIME,
>    if attach the MAX_TRY_TIMES, the server will lock, any user can not connect again
>    before REJECT_TIME attached. The old connected client will not be influenced.

i.e. effectively rate-limit login attempts.  Makes sense to have an
option for that, although I'm not sure it is worth the trouble doing
something beyond a simple "one attempt per second allowed" (i.e. stop
polling the listening socket for a second after each accept).

cheers,
  Gerd