From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xg9OI-00026D-5v for qemu-devel@nongnu.org; Mon, 20 Oct 2014 05:36:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xg9OC-0008WL-1x for qemu-devel@nongnu.org; Mon, 20 Oct 2014 05:36:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xg9OB-0008WD-R0 for qemu-devel@nongnu.org; Mon, 20 Oct 2014 05:36:31 -0400 Date: Mon, 20 Oct 2014 12:40:02 +0300 From: "Michael S. Tsirkin" Message-ID: <1413797938-18100-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , Anthony Liguori , Le Tan (((sid) >> 8) && 0xff) makes no sense (((sid) >> 8) & 0xff) seems to be what was meant. Suggested-by: Markus Armbruster Signed-off-by: Michael S. Tsirkin --- Compile-tested only. include/hw/i386/intel_iommu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h index f4701e1..e321ee4 100644 --- a/include/hw/i386/intel_iommu.h +++ b/include/hw/i386/intel_iommu.h @@ -37,7 +37,7 @@ #define VTD_PCI_DEVFN_MAX 256 #define VTD_PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) #define VTD_PCI_FUNC(devfn) ((devfn) & 0x07) -#define VTD_SID_TO_BUS(sid) (((sid) >> 8) && 0xff) +#define VTD_SID_TO_BUS(sid) (((sid) >> 8) & 0xff) #define VTD_SID_TO_DEVFN(sid) ((sid) & 0xff) #define DMAR_REG_SIZE 0x230 -- MST