From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgD8i-0005H3-JW for qemu-devel@nongnu.org; Mon, 20 Oct 2014 09:36:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgD8d-0007QC-I1 for qemu-devel@nongnu.org; Mon, 20 Oct 2014 09:36:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgD8d-0007Py-BI for qemu-devel@nongnu.org; Mon, 20 Oct 2014 09:36:43 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9KDagOW030985 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 20 Oct 2014 09:36:42 -0400 From: Kevin Wolf Date: Mon, 20 Oct 2014 15:35:54 +0200 Message-Id: <1413812154-11153-29-git-send-email-kwolf@redhat.com> In-Reply-To: <1413812154-11153-1-git-send-email-kwolf@redhat.com> References: <1413812154-11153-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 28/28] block: Make device model's references to BlockBackend strong List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com From: Markus Armbruster Doesn't make a difference just yet, but it's the right thing to do. Signed-off-by: Markus Armbruster Reviewed-by: Beno=C3=AEt Canet Reviewed-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- block/block-backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index bdcbac6..d0692b1 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -257,6 +257,7 @@ int blk_attach_dev(BlockBackend *blk, void *dev) if (blk->dev) { return -EBUSY; } + blk_ref(blk); blk->dev =3D dev; bdrv_iostatus_reset(blk->bs); =20 @@ -290,6 +291,7 @@ void blk_detach_dev(BlockBackend *blk, void *dev) blk->dev_opaque =3D NULL; bdrv_set_guest_block_size(blk->bs, 512); qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION); + blk_unref(blk); } =20 /* --=20 1.8.3.1