From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgE3s-0001Sy-0k for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:35:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgE3k-0005o6-AM for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:35:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgE3k-0005np-32 for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:35:44 -0400 From: Max Reitz Date: Mon, 20 Oct 2014 16:35:24 +0200 Message-Id: <1413815733-22829-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1413815733-22829-1-git-send-email-mreitz@redhat.com> References: <1413815733-22829-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v6 02/11] qcow2: Fix leaks in dirty images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?q?Beno=C3=AEt=20Canet?= , Stefan Hajnoczi , Max Reitz When opening dirty images, qcow2's repair function should not only repair errors but leaks as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Beno=C3=AEt Canet --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3c8b881..7a2c66f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -910,7 +910,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *op= tions, int flags, (s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) { BdrvCheckResult result =3D {0}; =20 - ret =3D qcow2_check(bs, &result, BDRV_FIX_ERRORS); + ret =3D qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAK= S); if (ret < 0) { error_setg_errno(errp, -ret, "Could not repair dirty image")= ; goto fail; --=20 2.1.2