From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XgXJq-0000Qa-Sf
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 07:09:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XgXJi-0004Le-5F
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 07:09:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XgXJh-0004LR-U8
	for qemu-devel@nongnu.org; Tue, 21 Oct 2014 07:09:30 -0400
Message-ID: <1413889759.14632.17.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 21 Oct 2014 13:09:19 +0200
In-Reply-To: <544556A1.3020405@redhat.com>
References: <1413796790-30579-1-git-send-email-armbru@redhat.com>
	<CAFEAcA_UxfVow0m2xu4+r8S-nK2Pb-jyNxmWhvXXP1G9V4Nerg@mail.gmail.com>
	<20141020141548.GA11062@redhat.com> <544556A1.3020405@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to
 --no-git-fallback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Mo, 2014-10-20 at 20:38 +0200, Paolo Bonzini wrote:
> On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote:
> > What do you want to happen in this case?
> > Won't this cause even more patches to fall to the floor?
> >
> > The benefit seems marginal, the risk high.
> 
> I agree with Michael.
> 
> Can we detect if get_maintainer.pl is invoked as a cccmd, and in this 
> case default to --no-git-fallback?  If it is invoked manually, I would 
> like to show the committers (I will then cherry pick the right ones).

How about making "get_maintainer.pl --git-fallback" actually do what it
says?  Right now git it *not* used as fallback, it goes to git log
unconditionally, even if there are hits in MAINTAINERS ...

Different behavior depending on whenever stdout is a tty or not should
be doable too.

cheers,
  Gerd