From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] tests: fix acpi tables regeneration script
Date: Wed, 22 Oct 2014 10:42:26 +0300 [thread overview]
Message-ID: <1413963746.2376.13.camel@localhost.localdomain> (raw)
In-Reply-To: <1413724361-29514-1-git-send-email-marcel.a@redhat.com>
On Sun, 2014-10-19 at 16:12 +0300, Marcel Apfelbaum wrote:
> Commit: 501f28ca9db08e84819b26314525b6369e7704dd
> tests: rename acpi-test to bios-tables-test
>
> modified acpi-test file from acpi-test.c to bios-tables-test.c.
> However, the tables regeneration script was not modified
> accordingly.
>
> Fixed the test name also in rebuild-expected-aml.sh script.
Mini PING
Thanks,
Marcel
>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
> tests/acpi-test-data/rebuild-expected-aml.sh | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh
> index ab98498..e7ce2b3 100755
> --- a/tests/acpi-test-data/rebuild-expected-aml.sh
> +++ b/tests/acpi-test-data/rebuild-expected-aml.sh
> @@ -12,6 +12,7 @@
> # See the COPYING.LIB file in the top-level directory.
>
> qemu=
> +acpi_test_path="tests/bios-tables-test"
>
> if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then
> qemu="x86_64-softmmu/qemu-system-x86_64"
> @@ -23,13 +24,13 @@ else
> exit 1;
> fi
>
> -if [ ! -e "tests/acpi-test" ]; then
> - echo "Test: acpi-test is required! Run make check before this script."
> +if [ ! -e $acpi_test_path ]; then
> + echo "Test: $acpi_test_path is required! Run make check before this script."
> echo "Run this script from the build directory."
> exit 1;
> fi
>
> -TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test
> +TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu $acpi_test_path
>
> echo "The files were rebuilt and can be added to git."
> echo "However, if new files were created, please copy them manually" \
next prev parent reply other threads:[~2014-10-22 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 13:12 [Qemu-devel] [PATCH] tests: fix acpi tables regeneration script Marcel Apfelbaum
2014-10-22 7:42 ` Marcel Apfelbaum [this message]
2014-10-22 8:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413963746.2376.13.camel@localhost.localdomain \
--to=marcel.apfelbaum@gmail.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).