From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1XgqZt-0001Nm-KA
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:43:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1XgqZm-00050E-IX
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:43:29 -0400
Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:50521)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1XgqZm-000502-AA
	for qemu-devel@nongnu.org; Wed, 22 Oct 2014 03:43:22 -0400
Received: by mail-lb0-f173.google.com with SMTP id 10so2341428lbg.4
	for <qemu-devel@nongnu.org>; Wed, 22 Oct 2014 00:43:20 -0700 (PDT)
Message-ID: <1413963746.2376.13.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Date: Wed, 22 Oct 2014 10:42:26 +0300
In-Reply-To: <1413724361-29514-1-git-send-email-marcel.a@redhat.com>
References: <1413724361-29514-1-git-send-email-marcel.a@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tests: fix acpi tables regeneration script
Reply-To: marcel.a@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com

On Sun, 2014-10-19 at 16:12 +0300, Marcel Apfelbaum wrote:
> Commit: 501f28ca9db08e84819b26314525b6369e7704dd
>     tests: rename acpi-test to bios-tables-test
> 
> modified acpi-test file from acpi-test.c to bios-tables-test.c.
> However, the tables regeneration script was not modified
> accordingly.
> 
> Fixed the test name also in rebuild-expected-aml.sh script.

Mini PING

Thanks,
Marcel

> 
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
>  tests/acpi-test-data/rebuild-expected-aml.sh | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh
> index ab98498..e7ce2b3 100755
> --- a/tests/acpi-test-data/rebuild-expected-aml.sh
> +++ b/tests/acpi-test-data/rebuild-expected-aml.sh
> @@ -12,6 +12,7 @@
>  # See the COPYING.LIB file in the top-level directory.
>  
>  qemu=
> +acpi_test_path="tests/bios-tables-test"
>  
>  if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then
>      qemu="x86_64-softmmu/qemu-system-x86_64"
> @@ -23,13 +24,13 @@ else
>      exit 1;
>  fi
>  
> -if [ ! -e "tests/acpi-test" ]; then
> -    echo "Test: acpi-test is required! Run make check before this script."
> +if [ ! -e $acpi_test_path ]; then
> +    echo "Test: $acpi_test_path is required! Run make check before this script."
>      echo "Run this script from the build directory."
>      exit 1;
>  fi
>  
> -TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test
> +TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu $acpi_test_path
>  
>  echo "The files were rebuilt and can be added to git."
>  echo "However, if new files were created, please copy them manually" \