From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgruJ-0000JR-V9 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 05:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgruC-0006By-6S for qemu-devel@nongnu.org; Wed, 22 Oct 2014 05:08:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgruC-0006Bu-00 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 05:08:32 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9M98VdL009595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 22 Oct 2014 05:08:31 -0400 From: Paolo Bonzini Date: Wed, 22 Oct 2014 11:08:20 +0200 Message-Id: <1413968902-24094-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1413968902-24094-1-git-send-email-pbonzini@redhat.com> References: <1413968902-24094-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 2/4] get_maintainer.pl: treat all M entries the same List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, mst@redhat.com Why should get_maintainer bother if someone puts his name as maintainer on an "Orphan" entry? Garbage in, email out. The results from the git fallback are likely to be from someone doing sweeping changes on the whole tree, and thus not really interesting. Reported-by: Gerd Hoffmann Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index a3a16d8..6c5a73b 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -505,24 +505,6 @@ if ($web) { exit($exit); -sub range_is_maintained { - my ($start, $end) = @_; - - for (my $i = $start; $i < $end; $i++) { - my $line = $typevalue[$i]; - if ($line =~ m/^(\C):\s*(.*)/) { - my $type = $1; - my $value = $2; - if ($type eq 'S') { - if ($value =~ /(maintain|support)/i) { - return 1; - } - } - } - } - return 0; -} - sub range_has_maintainer { my ($start, $end) = @_; @@ -602,7 +584,6 @@ sub get_maintainers { $value_pd++ if (substr($value,-1,1) ne "/"); $value_pd = -1 if ($value =~ /^\.\*/); if ($value_pd >= $file_pd && - range_is_maintained($start, $end) && range_has_maintainer($start, $end)) { $exact_pattern_match_hash{$file} = 1; } -- 1.8.3.1