From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgtMP-0007do-7J for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:41:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgtMJ-0007nP-O2 for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:41:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgtMJ-0007nJ-FF for qemu-devel@nongnu.org; Wed, 22 Oct 2014 06:41:39 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9MAfcDM023134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 22 Oct 2014 06:41:38 -0400 From: Paolo Bonzini Date: Wed, 22 Oct 2014 12:41:33 +0200 Message-Id: <1413974493-2685-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/4] get_maintainer.pl: restrict cases where it falls back to --git List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, mst@redhat.com The list emitted by --git-fallback often leads inexperienced contributors to add pointless CCs. While not discouraging usage of --git-fallback, we want to: 1) disable the fallback if only some files lack a maintainer $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c Kevin Wolf (odd fixer:IDE) Stefan Hajnoczi (odd fixer:IDE) This behavior is taken even if --git-fallback is specified. 2) warn the contributors about what we're doing, asking them to use their common sense: $ scripts/get_maintainer.pl -f util/cutils.c get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. Luiz Capitulino (commit_signer:1/2=50%) ... $ Explicitly disabling the fallback will not result in the warning message: $ scripts/get_maintainer.pl -f util/cutils.c --no-git-fallback $ echo $? 1 Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 7c6d186..f4fee27 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -633,6 +633,15 @@ sub get_maintainers { } if ($email) { + if (! $interactive) { + $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame; + if ($email_git_fallback) { + print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n"; + print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n"; + print STDERR "\n"; + } + } + foreach my $file (@files) { if ($email_git || ($email_git_fallback && !$exact_pattern_match_hash{$file})) { -- 1.8.3.1