* [Qemu-devel] [PATCH v2 4/4] get_maintainer.pl: restrict cases where it falls back to --git
@ 2014-10-22 10:41 Paolo Bonzini
2014-10-22 12:56 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2014-10-22 10:41 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru, mst
The list emitted by --git-fallback often leads inexperienced contributors
to add pointless CCs. While not discouraging usage of --git-fallback,
we want to:
1) disable the fallback if only some files lack a maintainer
$ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c
Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)
This behavior is taken even if --git-fallback is specified.
2) warn the contributors about what we're doing, asking them to use their
common sense:
$ scripts/get_maintainer.pl -f util/cutils.c
get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
Luiz Capitulino <lcapitulino@redhat.com> (commit_signer:1/2=50%)
...
$
Explicitly disabling the fallback will not result in the warning message:
$ scripts/get_maintainer.pl -f util/cutils.c --no-git-fallback
$ echo $?
1
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/get_maintainer.pl | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7c6d186..f4fee27 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -633,6 +633,15 @@ sub get_maintainers {
}
if ($email) {
+ if (! $interactive) {
+ $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame;
+ if ($email_git_fallback) {
+ print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n";
+ print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n";
+ print STDERR "\n";
+ }
+ }
+
foreach my $file (@files) {
if ($email_git || ($email_git_fallback &&
!$exact_pattern_match_hash{$file})) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v2 4/4] get_maintainer.pl: restrict cases where it falls back to --git
2014-10-22 10:41 [Qemu-devel] [PATCH v2 4/4] get_maintainer.pl: restrict cases where it falls back to --git Paolo Bonzini
@ 2014-10-22 12:56 ` Markus Armbruster
2014-10-22 13:45 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2014-10-22 12:56 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, mst
Paolo Bonzini <pbonzini@redhat.com> writes:
> The list emitted by --git-fallback often leads inexperienced contributors
> to add pointless CCs. While not discouraging usage of --git-fallback,
> we want to:
>
> 1) disable the fallback if only some files lack a maintainer
>
> $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c
> Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
> Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)
>
> This behavior is taken even if --git-fallback is specified.
>
> 2) warn the contributors about what we're doing, asking them to use their
> common sense:
>
> $ scripts/get_maintainer.pl -f util/cutils.c
> get_maintainer.pl: No maintainers found, printing recent contributors.
> get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
>
> Luiz Capitulino <lcapitulino@redhat.com> (commit_signer:1/2=50%)
> ...
> $
>
> Explicitly disabling the fallback will not result in the warning message:
>
> $ scripts/get_maintainer.pl -f util/cutils.c --no-git-fallback
> $ echo $?
> 1
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/get_maintainer.pl | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 7c6d186..f4fee27 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -633,6 +633,15 @@ sub get_maintainers {
> }
>
> if ($email) {
> + if (! $interactive) {
> + $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame;
> + if ($email_git_fallback) {
> + print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n";
> + print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n";
> + print STDERR "\n";
> + }
> + }
> +
> foreach my $file (@files) {
> if ($email_git || ($email_git_fallback &&
> !$exact_pattern_match_hash{$file})) {
I liked v1 better.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v2 4/4] get_maintainer.pl: restrict cases where it falls back to --git
2014-10-22 12:56 ` Markus Armbruster
@ 2014-10-22 13:45 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2014-10-22 13:45 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, mst
On 10/22/2014 02:56 PM, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> The list emitted by --git-fallback often leads inexperienced contributors
>> to add pointless CCs. While not discouraging usage of --git-fallback,
>> we want to:
>>
>> 1) disable the fallback if only some files lack a maintainer
>>
>> $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c
>> Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
>> Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)
>>
>> This behavior is taken even if --git-fallback is specified.
>>
>> 2) warn the contributors about what we're doing, asking them to use their
>> common sense:
>>
>> $ scripts/get_maintainer.pl -f util/cutils.c
>> get_maintainer.pl: No maintainers found, printing recent contributors.
>> get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
>>
>> Luiz Capitulino <lcapitulino@redhat.com> (commit_signer:1/2=50%)
>> ...
>> $
>>
>> Explicitly disabling the fallback will not result in the warning message:
>>
>> $ scripts/get_maintainer.pl -f util/cutils.c --no-git-fallback
>> $ echo $?
>> 1
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> scripts/get_maintainer.pl | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
>> index 7c6d186..f4fee27 100755
>> --- a/scripts/get_maintainer.pl
>> +++ b/scripts/get_maintainer.pl
>> @@ -633,6 +633,15 @@ sub get_maintainers {
>> }
>>
>> if ($email) {
>> + if (! $interactive) {
>> + $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame;
>> + if ($email_git_fallback) {
>> + print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n";
>> + print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n";
>> + print STDERR "\n";
>> + }
>> + }
>> +
>> foreach my $file (@files) {
>> if ($email_git || ($email_git_fallback &&
>> !$exact_pattern_match_hash{$file})) {
>
> I liked v1 better.
Me too, but we can start with this. It's better than the status quo,
and the difference overall is small (the important part is disabling
fallback---with no message---on @email_to || @list_to).
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-22 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 10:41 [Qemu-devel] [PATCH v2 4/4] get_maintainer.pl: restrict cases where it falls back to --git Paolo Bonzini
2014-10-22 12:56 ` Markus Armbruster
2014-10-22 13:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).