From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v8 16/17] iotests: Fix test outputs
Date: Wed, 22 Oct 2014 14:09:42 +0200 [thread overview]
Message-ID: <1413979783-1549-17-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1413979783-1549-1-git-send-email-mreitz@redhat.com>
039, 060 and 061 all create images with referenced clusters having a
refcount of 0. Because previous commits changed handling of such errors,
these tests now have a different output. Fix it.
Furthermore, 060 created a refblock with a refcount greater than one
which now results in having to rebuild the refcount structure as well.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
tests/qemu-iotests/039.out | 10 ++++++++--
tests/qemu-iotests/060.out | 10 ++++++++--
tests/qemu-iotests/061.out | 18 ++++++++++++------
3 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/tests/qemu-iotests/039.out b/tests/qemu-iotests/039.out
index 67e7744..0adf153 100644
--- a/tests/qemu-iotests/039.out
+++ b/tests/qemu-iotests/039.out
@@ -25,7 +25,10 @@ read 512/512 bytes at offset 0
incompatible_features 0x1
== Repairing the image file must succeed ==
-Repairing cluster 5 refcount=0 reference=1
+ERROR cluster 5 refcount=0 reference=1
+Rebuilding refcount structure
+Repairing cluster 1 refcount=1 reference=0
+Repairing cluster 2 refcount=1 reference=0
The following inconsistencies were found and repaired:
0 leaked clusters
@@ -45,7 +48,10 @@ wrote 512/512 bytes at offset 0
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
./039: Aborted ( ulimit -c 0; exec "$@" )
incompatible_features 0x1
-Repairing cluster 5 refcount=0 reference=1
+ERROR cluster 5 refcount=0 reference=1
+Rebuilding refcount structure
+Repairing cluster 1 refcount=1 reference=0
+Repairing cluster 2 refcount=1 reference=0
wrote 512/512 bytes at offset 0
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
incompatible_features 0x0
diff --git a/tests/qemu-iotests/060.out b/tests/qemu-iotests/060.out
index cd679f9..9419da1 100644
--- a/tests/qemu-iotests/060.out
+++ b/tests/qemu-iotests/060.out
@@ -36,11 +36,15 @@ incompatible_features 0x0
qcow2: Marking image as corrupt: Preventing invalid write on metadata (overlaps with refcount block); further corruption events will be suppressed
write failed: Input/output error
incompatible_features 0x2
-Repairing refcount block 0 refcount=2
+ERROR refcount block 0 refcount=2
+ERROR cluster 2 refcount=1 reference=2
+Rebuilding refcount structure
+Repairing cluster 1 refcount=1 reference=0
+Repairing cluster 2 refcount=2 reference=1
The following inconsistencies were found and repaired:
0 leaked clusters
- 1 corruptions
+ 2 corruptions
Double checking the fixed image now...
No errors were found on the image.
@@ -68,6 +72,8 @@ incompatible_features 0x0
qcow2: Marking image as corrupt: Preventing invalid write on metadata (overlaps with inactive L2 table); further corruption events will be suppressed
write failed: Input/output error
incompatible_features 0x2
+ERROR cluster 4 refcount=1 reference=2
+Leaked cluster 9 refcount=1 reference=0
Repairing cluster 4 refcount=1 reference=2
Repairing cluster 9 refcount=1 reference=0
Repairing OFLAG_COPIED data cluster: l2_entry=8000000000040000 refcount=2
diff --git a/tests/qemu-iotests/061.out b/tests/qemu-iotests/061.out
index e372470..4ae6472 100644
--- a/tests/qemu-iotests/061.out
+++ b/tests/qemu-iotests/061.out
@@ -76,8 +76,11 @@ autoclear_features 0x0
refcount_order 4
header_length 104
-Repairing cluster 5 refcount=0 reference=1
-Repairing cluster 6 refcount=0 reference=1
+ERROR cluster 5 refcount=0 reference=1
+ERROR cluster 6 refcount=0 reference=1
+Rebuilding refcount structure
+Repairing cluster 1 refcount=1 reference=0
+Repairing cluster 2 refcount=1 reference=0
magic 0x514649fb
version 2
backing_file_offset 0x0
@@ -87,7 +90,7 @@ size 67108864
crypt_method 0
l1_size 1
l1_table_offset 0x30000
-refcount_table_offset 0x10000
+refcount_table_offset 0x80000
refcount_table_clusters 1
nb_snapshots 0
snapshot_offset 0x0
@@ -230,8 +233,11 @@ autoclear_features 0x0
refcount_order 4
header_length 104
-Repairing cluster 5 refcount=0 reference=1
-Repairing cluster 6 refcount=0 reference=1
+ERROR cluster 5 refcount=0 reference=1
+ERROR cluster 6 refcount=0 reference=1
+Rebuilding refcount structure
+Repairing cluster 1 refcount=1 reference=0
+Repairing cluster 2 refcount=1 reference=0
magic 0x514649fb
version 3
backing_file_offset 0x0
@@ -241,7 +247,7 @@ size 67108864
crypt_method 0
l1_size 1
l1_table_offset 0x30000
-refcount_table_offset 0x10000
+refcount_table_offset 0x80000
refcount_table_clusters 1
nb_snapshots 0
snapshot_offset 0x0
--
1.9.3
next prev parent reply other threads:[~2014-10-22 12:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 12:09 [Qemu-devel] [PATCH v8 00/17] qcow2: Fix image repairing Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 01/17] block: Add qemu_{, try_}blockalign0() Max Reitz
2014-10-22 14:02 ` Eric Blake
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 02/17] qcow2: Calculate refcount block entry count Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 03/17] qcow2: Fix leaks in dirty images Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 04/17] qcow2: Split qcow2_check_refcounts() Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table) Max Reitz
2014-10-22 14:38 ` Eric Blake
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 06/17] qcow2: Pull check_refblocks() up Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 07/17] qcow2: Use int64_t for in-memory reftable size Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 08/17] qcow2: Split fail code in L1 and L2 checks Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 09/17] qcow2: Let inc_refcounts() return -errno Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 10/17] qcow2: Let inc_refcounts() resize the reftable Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 11/17] qcow2: Reuse refcount table in calculate_refcounts() Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 12/17] qcow2: Fix refcount blocks beyond image end Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 13/17] qcow2: Do not perform potentially damaging repairs Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 14/17] qcow2: Rebuild refcount structure during check Max Reitz
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 15/17] qcow2: Clean up after refcount rebuild Max Reitz
2014-10-22 12:09 ` Max Reitz [this message]
2014-10-22 12:09 ` [Qemu-devel] [PATCH v8 17/17] iotests: Add test for potentially damaging repairs Max Reitz
2014-10-22 13:18 ` [Qemu-devel] [PATCH v8 00/17] qcow2: Fix image repairing Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413979783-1549-17-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).