From: Gerd Hoffmann <kraxel@redhat.com>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, qemu-devel@nongnu.org,
peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open()
Date: Thu, 23 Oct 2014 09:52:40 +0200 [thread overview]
Message-ID: <1414050760.30724.3.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1414046016-10360-1-git-send-email-arei.gonglei@huawei.com>
On Do, 2014-10-23 at 14:33 +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> When using qmp change vnc interface, will leak fd
> of vs->lsock and vs->lwebsock (if configed). Close
> them before: re-evaluate.
I think we can do that before "if (reverse)", then we'll need the code
only once.
cheers,
Gerd
next prev parent reply other threads:[~2014-10-23 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 6:33 [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open() arei.gonglei
2014-10-23 7:52 ` Gerd Hoffmann [this message]
2014-10-23 7:57 ` Gerd Hoffmann
2014-10-23 8:05 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414050760.30724.3.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).