From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XhDGo-0007c2-NQ
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 03:57:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XhDGj-0001UD-Qs
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 03:57:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XhDGj-0001U6-Ig
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 03:57:13 -0400
Message-ID: <1414051026.30724.4.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 23 Oct 2014 09:57:06 +0200
In-Reply-To: <1414046016-10360-1-git-send-email-arei.gonglei@huawei.com>
References: <1414046016-10360-1-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com

On Do, 2014-10-23 at 14:33 +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> When using qmp change vnc interface, will leak fd
> of vs->lsock and vs->lwebsock (if configed). Close
> them before: re-evaluate.

Ah, the file handles are leaked because you dropped the
vnc_display_close() call.  Don't do that then ...

cheers,
  Gerd