From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhIXA-0005Vn-LL for qemu-devel@nongnu.org; Thu, 23 Oct 2014 09:34:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhIX1-0007ID-LR for qemu-devel@nongnu.org; Thu, 23 Oct 2014 09:34:32 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:52146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhIX1-0007I5-EB for qemu-devel@nongnu.org; Thu, 23 Oct 2014 09:34:23 -0400 Received: by mail-wi0-f173.google.com with SMTP id ex7so1795900wid.12 for ; Thu, 23 Oct 2014 06:34:22 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 23 Oct 2014 15:33:50 +0200 Message-Id: <1414071252-7003-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1414071252-7003-1-git-send-email-pbonzini@redhat.com> References: <1414071252-7003-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 02/24] virtio-scsi: dataplane: print why starting failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Cornelia Huck From: Cornelia Huck Setting up guest or host notifiers may fail, but the user will have no idea why: Let's print the error returned by the callback. Signed-off-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 97c2a4f..ca9af13 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -45,10 +45,13 @@ static VirtIOSCSIVring *virtio_scsi_vring_init(VirtIOSCSI *s, BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s))); VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); VirtIOSCSIVring *r = g_slice_new(VirtIOSCSIVring); + int rc; /* Set up virtqueue notify */ - if (k->set_host_notifier(qbus->parent, n, true) != 0) { - fprintf(stderr, "virtio-scsi: Failed to set host notifier\n"); + rc = k->set_host_notifier(qbus->parent, n, true); + if (rc != 0) { + fprintf(stderr, "virtio-scsi: Failed to set host notifier (%d)\n", + rc); exit(1); } r->host_notifier = *virtio_queue_get_host_notifier(vq); @@ -159,8 +162,8 @@ void virtio_scsi_dataplane_start(VirtIOSCSI *s) /* Set up guest notifier (irq) */ rc = k->set_guest_notifiers(qbus->parent, vs->conf.num_queues + 2, true); if (rc != 0) { - fprintf(stderr, "virtio-scsi: Failed to set guest notifiers, " - "ensure -enable-kvm is set\n"); + fprintf(stderr, "virtio-scsi: Failed to set guest notifiers (%d), " + "ensure -enable-kvm is set\n", rc); exit(1); } -- 1.8.3.1