qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
	ronniesahlberg@gmail.com, Peter Lieven <pl@kamp.de>,
	armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length
Date: Sat, 25 Oct 2014 18:18:35 +0200	[thread overview]
Message-ID: <1414253919-3044-4-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1414253919-3044-1-git-send-email-pl@kamp.de>

Copy the max_xfer_len from the BlockLimits VPD or use the
maximum value fitting in the CDB.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block/iscsi.c |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index 233f462..1ae4add 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -297,6 +297,11 @@ static int64_t sector_lun2qemu(int64_t sector, IscsiLun *iscsilun)
     return sector * iscsilun->block_size / BDRV_SECTOR_SIZE;
 }
 
+static int nb_sectors_lun2qemu(int64_t sector, IscsiLun *iscsilun)
+{
+    return MIN(sector_lun2qemu(sector, iscsilun), INT_MAX);
+}
+
 static int64_t sector_qemu2lun(int64_t sector, IscsiLun *iscsilun)
 {
     return sector * BDRV_SECTOR_SIZE / iscsilun->block_size;
@@ -1449,10 +1454,18 @@ static void iscsi_close(BlockDriverState *bs)
 
 static void iscsi_refresh_limits(BlockDriverState *bs, Error **errp)
 {
-    IscsiLun *iscsilun = bs->opaque;
-
     /* We don't actually refresh here, but just return data queried in
      * iscsi_open(): iscsi targets don't change their limits. */
+
+    IscsiLun *iscsilun = bs->opaque;
+    uint32_t max_xfer_len = iscsilun->use_16_for_rw ? 0xffffffff : 0xffff;
+
+    if (iscsilun->bl.max_xfer_len) {
+        max_xfer_len = MIN(max_xfer_len, iscsilun->bl.max_xfer_len);
+    }
+
+    bs->bl.max_transfer_length = nb_sectors_lun2qemu(max_xfer_len, iscsilun);
+
     if (iscsilun->lbp.lbpu) {
         if (iscsilun->bl.max_unmap < 0xffffffff) {
             bs->bl.max_discard = sector_lun2qemu(iscsilun->bl.max_unmap,
-- 
1.7.9.5

  parent reply	other threads:[~2014-10-25 16:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-25 16:18 [Qemu-devel] [PATCHv5 0/6] introduce max_transfer_length Peter Lieven
2014-10-25 16:18 ` [Qemu-devel] [PATCHv5 1/6] util: introduce MIN_NON_ZERO Peter Lieven
2014-10-27  8:24   ` Max Reitz
2014-10-25 16:18 ` [Qemu-devel] [PATCHv5 2/6] BlockLimits: introduce max_transfer_length Peter Lieven
2014-10-25 16:18 ` Peter Lieven [this message]
2014-10-27  8:28   ` [Qemu-devel] [PATCHv5 3/6] block/iscsi: set max_transfer_length Max Reitz
2014-10-27  8:36     ` Peter Lieven
2014-10-27  8:44       ` Max Reitz
2014-10-27  8:47         ` Peter Lieven
2014-10-27  9:04           ` Max Reitz
2014-10-25 16:18 ` [Qemu-devel] [PATCHv5 4/6] block: avoid creating oversized writes in multiwrite_merge Peter Lieven
2014-10-25 16:18 ` [Qemu-devel] [PATCHv5 5/6] block/iscsi: limit to INT_MAX throughout iscsi_refresh_limits Peter Lieven
2014-10-27  8:32   ` Max Reitz
2014-10-27  8:35     ` Peter Lieven
2014-10-27  8:38       ` Max Reitz
2014-10-25 16:18 ` [Qemu-devel] [PATCHv5 6/6] block/iscsi: check for oversized requests Peter Lieven
2014-10-27  8:35   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414253919-3044-4-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).