From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xig2d-0007Ol-Dj for qemu-devel@nongnu.org; Mon, 27 Oct 2014 04:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xig2X-0004pZ-EK for qemu-devel@nongnu.org; Mon, 27 Oct 2014 04:52:43 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:48732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xig2W-0004G9-OZ for qemu-devel@nongnu.org; Mon, 27 Oct 2014 04:52:37 -0400 From: Ting Wang Date: Mon, 27 Oct 2014 16:51:41 +0800 Message-ID: <1414399901-231824-1-git-send-email-kathy.wangting@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH] virtio-scsi: sense in virtio_scsi_command_complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: pbonzini@redhat.com, qemu-devel@nongnu.org Cc: Ting Wang If req->resp.cmd.status is not GOOD, the address of sense for qemu_iovec_from_buf should be modified from &req->resp to sense. Signed-off-by: Ting Wang --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index a1725b8..fe094a5 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -448,7 +448,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status, sense_len = scsi_req_get_sense(r, sense, sizeof(sense)); sense_len = MIN(sense_len, req->resp_iov.size - sizeof(req->resp.cmd)); qemu_iovec_from_buf(&req->resp_iov, sizeof(req->resp.cmd), - &req->resp, sense_len); + sense, sense_len); req->resp.cmd.sense_len = virtio_tswap32(vdev, sense_len); } virtio_scsi_complete_cmd_req(req); -- 1.8.5