* [Qemu-devel] [PATCH] virtio-scsi: sense in virtio_scsi_command_complete
@ 2014-10-27 8:51 Ting Wang
2014-10-27 9:22 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Ting Wang @ 2014-10-27 8:51 UTC (permalink / raw)
To: pbonzini, qemu-devel; +Cc: Ting Wang
If req->resp.cmd.status is not GOOD, the address of sense for
qemu_iovec_from_buf should be modified from &req->resp to sense.
Signed-off-by: Ting Wang <kathy.wangting@huawei.com>
---
hw/scsi/virtio-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index a1725b8..fe094a5 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -448,7 +448,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status,
sense_len = scsi_req_get_sense(r, sense, sizeof(sense));
sense_len = MIN(sense_len, req->resp_iov.size - sizeof(req->resp.cmd));
qemu_iovec_from_buf(&req->resp_iov, sizeof(req->resp.cmd),
- &req->resp, sense_len);
+ sense, sense_len);
req->resp.cmd.sense_len = virtio_tswap32(vdev, sense_len);
}
virtio_scsi_complete_cmd_req(req);
--
1.8.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-scsi: sense in virtio_scsi_command_complete
2014-10-27 8:51 [Qemu-devel] [PATCH] virtio-scsi: sense in virtio_scsi_command_complete Ting Wang
@ 2014-10-27 9:22 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-10-27 9:22 UTC (permalink / raw)
To: Ting Wang, qemu-devel
On 10/27/2014 09:51 AM, Ting Wang wrote:
> If req->resp.cmd.status is not GOOD, the address of sense for
> qemu_iovec_from_buf should be modified from &req->resp to sense.
>
> Signed-off-by: Ting Wang <kathy.wangting@huawei.com>
> ---
> hw/scsi/virtio-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index a1725b8..fe094a5 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -448,7 +448,7 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status,
> sense_len = scsi_req_get_sense(r, sense, sizeof(sense));
> sense_len = MIN(sense_len, req->resp_iov.size - sizeof(req->resp.cmd));
> qemu_iovec_from_buf(&req->resp_iov, sizeof(req->resp.cmd),
> - &req->resp, sense_len);
> + sense, sense_len);
> req->resp.cmd.sense_len = virtio_tswap32(vdev, sense_len);
> }
> virtio_scsi_complete_cmd_req(req);
>
Embarrassing. Thanks, applied.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-27 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-27 8:51 [Qemu-devel] [PATCH] virtio-scsi: sense in virtio_scsi_command_complete Ting Wang
2014-10-27 9:22 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).