From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XijRJ-0006jj-8D for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:30:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XijRD-0000lM-5C for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:30:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XijRC-0000lF-V3 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:30:19 -0400 From: Max Reitz Date: Mon, 27 Oct 2014 13:30:07 +0100 Message-Id: <1414413009-9008-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi , Max Reitz Currently, when trying to create a backed image without specifying its size, when the backing file does not exist or is not accessible, an appropriate error message will be generated which is then (in bdrv_img_create()) prefixed with the image file name and the strerror(). However, both are generally already part of the bdrv_open() error message, so we should not double this information. An example: $ qemu-img create -f qcow2 -b /tmp/enoent /tmp/img.qcow2 qemu-img: /tmp/img.qcow2: Could not open '/tmp/enoent': Could not open '/tmp/enoent': No such file or directory: No such file or directory Just propagating the error is sufficient: $ qemu-img create -f qcow2 -b /tmp/enoent /tmp/img.qcow2 qemu-img /tmp/img.qcow2: Could not open '/tmp/enoent': No such file or directory Max Reitz (2): block: Propagate error in bdrv_img_create() iotests: Add test for non-existing backing file block.c | 5 ----- tests/qemu-iotests/111 | 53 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/111.out | 3 +++ tests/qemu-iotests/group | 1 + 4 files changed, 57 insertions(+), 5 deletions(-) create mode 100755 tests/qemu-iotests/111 create mode 100644 tests/qemu-iotests/111.out -- 1.9.3