From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XijRu-0007NP-T3 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XijRo-0000py-DR for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:31:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XijRo-0000pq-5j for qemu-devel@nongnu.org; Mon, 27 Oct 2014 08:30:56 -0400 From: Max Reitz Date: Mon, 27 Oct 2014 13:30:08 +0100 Message-Id: <1414413009-9008-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1414413009-9008-1-git-send-email-mreitz@redhat.com> References: <1414413009-9008-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] block: Propagate error in bdrv_img_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Stefan Hajnoczi , Max Reitz If the specified backing file could not be opened, do not generate a new error message which contains the message which has been generated by bdrv_open(), but just propagate the latter. Signed-off-by: Max Reitz --- block.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/block.c b/block.c index 88f6d9b..44fa908 100644 --- a/block.c +++ b/block.c @@ -5577,11 +5577,6 @@ void bdrv_img_create(const char *filename, const char *fmt, ret = bdrv_open(&bs, backing_file, NULL, NULL, back_flags, backing_drv, &local_err); if (ret < 0) { - error_setg_errno(errp, -ret, "Could not open '%s': %s", - backing_file, - error_get_pretty(local_err)); - error_free(local_err); - local_err = NULL; goto out; } size = bdrv_getlength(bs); -- 1.9.3